Delete bit masks from trace help (found inside build/bin/spdk_tgt -h help text), as they do not provide useful information, are much harder to remember and use, and migh leave user confused. Since we provide trace group names anyway, bit masks are excessive. Change --tpoint-group-mask parameter name to --tpoint-group, because we do not provide bit masks anymore. Drop "default" tpoint group mask from help text, since it does not enable any tracepoints and may confuse the user. Change-Id: I2ca780883dfa7822e76523e9ba1fc65a7bfe5a99 Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14656 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
452 lines
10 KiB
C
452 lines
10 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*/
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk/env.h"
|
|
#include "spdk/trace.h"
|
|
#include "spdk/log.h"
|
|
#include "spdk/util.h"
|
|
|
|
struct spdk_trace_flags *g_trace_flags = NULL;
|
|
static struct spdk_trace_register_fn *g_reg_fn_head = NULL;
|
|
|
|
SPDK_LOG_REGISTER_COMPONENT(trace)
|
|
|
|
uint64_t
|
|
spdk_trace_get_tpoint_mask(uint32_t group_id)
|
|
{
|
|
if (group_id >= SPDK_TRACE_MAX_GROUP_ID) {
|
|
SPDK_ERRLOG("invalid group ID %d\n", group_id);
|
|
return 0ULL;
|
|
}
|
|
|
|
if (g_trace_flags == NULL) {
|
|
return 0ULL;
|
|
}
|
|
|
|
return g_trace_flags->tpoint_mask[group_id];
|
|
}
|
|
|
|
void
|
|
spdk_trace_set_tpoints(uint32_t group_id, uint64_t tpoint_mask)
|
|
{
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
if (group_id >= SPDK_TRACE_MAX_GROUP_ID) {
|
|
SPDK_ERRLOG("invalid group ID %d\n", group_id);
|
|
return;
|
|
}
|
|
|
|
g_trace_flags->tpoint_mask[group_id] |= tpoint_mask;
|
|
}
|
|
|
|
void
|
|
spdk_trace_clear_tpoints(uint32_t group_id, uint64_t tpoint_mask)
|
|
{
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
if (group_id >= SPDK_TRACE_MAX_GROUP_ID) {
|
|
SPDK_ERRLOG("invalid group ID %d\n", group_id);
|
|
return;
|
|
}
|
|
|
|
g_trace_flags->tpoint_mask[group_id] &= ~tpoint_mask;
|
|
}
|
|
|
|
uint64_t
|
|
spdk_trace_get_tpoint_group_mask(void)
|
|
{
|
|
uint64_t mask = 0x0;
|
|
int i;
|
|
|
|
for (i = 0; i < SPDK_TRACE_MAX_GROUP_ID; i++) {
|
|
if (spdk_trace_get_tpoint_mask(i) != 0) {
|
|
mask |= (1ULL << i);
|
|
}
|
|
}
|
|
|
|
return mask;
|
|
}
|
|
|
|
void
|
|
spdk_trace_set_tpoint_group_mask(uint64_t tpoint_group_mask)
|
|
{
|
|
int i;
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < SPDK_TRACE_MAX_GROUP_ID; i++) {
|
|
if (tpoint_group_mask & (1ULL << i)) {
|
|
spdk_trace_set_tpoints(i, -1ULL);
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
spdk_trace_clear_tpoint_group_mask(uint64_t tpoint_group_mask)
|
|
{
|
|
int i;
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < SPDK_TRACE_MAX_GROUP_ID; i++) {
|
|
if (tpoint_group_mask & (1ULL << i)) {
|
|
spdk_trace_clear_tpoints(i, -1ULL);
|
|
}
|
|
}
|
|
}
|
|
|
|
struct spdk_trace_register_fn *
|
|
spdk_trace_get_first_register_fn(void)
|
|
{
|
|
return g_reg_fn_head;
|
|
}
|
|
|
|
struct spdk_trace_register_fn *
|
|
spdk_trace_get_next_register_fn(struct spdk_trace_register_fn *register_fn)
|
|
{
|
|
return register_fn->next;
|
|
}
|
|
|
|
uint64_t
|
|
spdk_trace_create_tpoint_group_mask(const char *group_name)
|
|
{
|
|
uint64_t tpoint_group_mask = 0;
|
|
struct spdk_trace_register_fn *register_fn;
|
|
|
|
register_fn = spdk_trace_get_first_register_fn();
|
|
if (strcmp(group_name, "all") == 0) {
|
|
while (register_fn) {
|
|
tpoint_group_mask |= (1UL << register_fn->tgroup_id);
|
|
|
|
register_fn = spdk_trace_get_next_register_fn(register_fn);
|
|
}
|
|
} else {
|
|
while (register_fn) {
|
|
if (strcmp(group_name, register_fn->name) == 0) {
|
|
break;
|
|
}
|
|
|
|
register_fn = spdk_trace_get_next_register_fn(register_fn);
|
|
}
|
|
|
|
if (register_fn != NULL) {
|
|
tpoint_group_mask |= (1UL << register_fn->tgroup_id);
|
|
}
|
|
}
|
|
|
|
return tpoint_group_mask;
|
|
}
|
|
|
|
int
|
|
spdk_trace_enable_tpoint_group(const char *group_name)
|
|
{
|
|
uint64_t tpoint_group_mask = 0;
|
|
|
|
if (g_trace_flags == NULL) {
|
|
return -1;
|
|
}
|
|
|
|
tpoint_group_mask = spdk_trace_create_tpoint_group_mask(group_name);
|
|
if (tpoint_group_mask == 0) {
|
|
return -1;
|
|
}
|
|
|
|
spdk_trace_set_tpoint_group_mask(tpoint_group_mask);
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
spdk_trace_disable_tpoint_group(const char *group_name)
|
|
{
|
|
uint64_t tpoint_group_mask = 0;
|
|
|
|
if (g_trace_flags == NULL) {
|
|
return -1;
|
|
}
|
|
|
|
tpoint_group_mask = spdk_trace_create_tpoint_group_mask(group_name);
|
|
if (tpoint_group_mask == 0) {
|
|
return -1;
|
|
}
|
|
|
|
spdk_trace_clear_tpoint_group_mask(tpoint_group_mask);
|
|
return 0;
|
|
}
|
|
|
|
void
|
|
spdk_trace_mask_usage(FILE *f, const char *tmask_arg)
|
|
{
|
|
struct spdk_trace_register_fn *register_fn;
|
|
bool first_group_name = true;
|
|
|
|
fprintf(f, " %s, --tpoint-group <group-name>[:<tpoint_mask>]\n", tmask_arg);
|
|
fprintf(f, " group_name - tracepoint group name ");
|
|
fprintf(f, "for spdk trace buffers (");
|
|
|
|
register_fn = g_reg_fn_head;
|
|
while (register_fn) {
|
|
if (first_group_name) {
|
|
fprintf(f, "%s", register_fn->name);
|
|
first_group_name = false;
|
|
} else {
|
|
fprintf(f, ", %s", register_fn->name);
|
|
}
|
|
register_fn = register_fn->next;
|
|
}
|
|
|
|
fprintf(f, ", all)\n");
|
|
fprintf(f, " tpoint_mask - tracepoint mask for enabling individual");
|
|
fprintf(f, " tpoints inside a tracepoint group.");
|
|
fprintf(f, " First tpoint inside a group can be");
|
|
fprintf(f, " enabled by setting tpoint_mask to 1 (e.g. bdev:0x1).\n");
|
|
fprintf(f, " Groups and masks can be combined (e.g.");
|
|
fprintf(f, " thread,bdev:0x1).\n");
|
|
fprintf(f, " All available tpoints can be found in");
|
|
fprintf(f, " /include/spdk_internal/trace_defs.h\n");
|
|
}
|
|
|
|
void
|
|
spdk_trace_register_owner(uint8_t type, char id_prefix)
|
|
{
|
|
struct spdk_trace_owner *owner;
|
|
|
|
assert(type != OWNER_NONE);
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
/* 'owner' has 256 entries and since 'type' is a uint8_t, it
|
|
* can't overrun the array.
|
|
*/
|
|
owner = &g_trace_flags->owner[type];
|
|
assert(owner->type == 0);
|
|
|
|
owner->type = type;
|
|
owner->id_prefix = id_prefix;
|
|
}
|
|
|
|
void
|
|
spdk_trace_register_object(uint8_t type, char id_prefix)
|
|
{
|
|
struct spdk_trace_object *object;
|
|
|
|
assert(type != OBJECT_NONE);
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
/* 'object' has 256 entries and since 'type' is a uint8_t, it
|
|
* can't overrun the array.
|
|
*/
|
|
object = &g_trace_flags->object[type];
|
|
assert(object->type == 0);
|
|
|
|
object->type = type;
|
|
object->id_prefix = id_prefix;
|
|
}
|
|
|
|
static void
|
|
trace_register_description(const struct spdk_trace_tpoint_opts *opts)
|
|
{
|
|
struct spdk_trace_tpoint *tpoint;
|
|
size_t i, max_name_length;
|
|
|
|
assert(opts->tpoint_id != 0);
|
|
assert(opts->tpoint_id < SPDK_TRACE_MAX_TPOINT_ID);
|
|
|
|
if (strnlen(opts->name, sizeof(tpoint->name)) == sizeof(tpoint->name)) {
|
|
SPDK_ERRLOG("name (%s) too long\n", opts->name);
|
|
}
|
|
|
|
tpoint = &g_trace_flags->tpoint[opts->tpoint_id];
|
|
assert(tpoint->tpoint_id == 0);
|
|
|
|
snprintf(tpoint->name, sizeof(tpoint->name), "%s", opts->name);
|
|
tpoint->tpoint_id = opts->tpoint_id;
|
|
tpoint->object_type = opts->object_type;
|
|
tpoint->owner_type = opts->owner_type;
|
|
tpoint->new_object = opts->new_object;
|
|
|
|
max_name_length = sizeof(tpoint->args[0].name);
|
|
for (i = 0; i < SPDK_TRACE_MAX_ARGS_COUNT; ++i) {
|
|
if (!opts->args[i].name || opts->args[i].name[0] == '\0') {
|
|
break;
|
|
}
|
|
|
|
switch (opts->args[i].type) {
|
|
case SPDK_TRACE_ARG_TYPE_INT:
|
|
case SPDK_TRACE_ARG_TYPE_PTR:
|
|
/* The integers and pointers have to be exactly 4 or 8 bytes */
|
|
assert(opts->args[i].size == 4 || opts->args[i].size == 8);
|
|
break;
|
|
case SPDK_TRACE_ARG_TYPE_STR:
|
|
/* Strings need to have at least one byte for the NULL terminator */
|
|
assert(opts->args[i].size > 0);
|
|
break;
|
|
default:
|
|
assert(0 && "invalid trace argument type");
|
|
break;
|
|
}
|
|
|
|
if (strnlen(opts->args[i].name, max_name_length) == max_name_length) {
|
|
SPDK_ERRLOG("argument name (%s) is too long\n", opts->args[i].name);
|
|
}
|
|
|
|
snprintf(tpoint->args[i].name, sizeof(tpoint->args[i].name),
|
|
"%s", opts->args[i].name);
|
|
tpoint->args[i].type = opts->args[i].type;
|
|
tpoint->args[i].size = opts->args[i].size;
|
|
}
|
|
|
|
tpoint->num_args = i;
|
|
}
|
|
|
|
void
|
|
spdk_trace_register_description_ext(const struct spdk_trace_tpoint_opts *opts, size_t num_opts)
|
|
{
|
|
size_t i;
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < num_opts; ++i) {
|
|
trace_register_description(&opts[i]);
|
|
}
|
|
}
|
|
|
|
void
|
|
spdk_trace_register_description(const char *name, uint16_t tpoint_id, uint8_t owner_type,
|
|
uint8_t object_type, uint8_t new_object,
|
|
uint8_t arg1_type, const char *arg1_name)
|
|
{
|
|
struct spdk_trace_tpoint_opts opts = {
|
|
.name = name,
|
|
.tpoint_id = tpoint_id,
|
|
.owner_type = owner_type,
|
|
.object_type = object_type,
|
|
.new_object = new_object,
|
|
.args = {{
|
|
.name = arg1_name,
|
|
.type = arg1_type,
|
|
.size = sizeof(uint64_t)
|
|
}
|
|
}
|
|
};
|
|
|
|
spdk_trace_register_description_ext(&opts, 1);
|
|
}
|
|
|
|
void
|
|
spdk_trace_tpoint_register_relation(uint16_t tpoint_id, uint8_t object_type, uint8_t arg_index)
|
|
{
|
|
struct spdk_trace_tpoint *tpoint;
|
|
uint16_t i;
|
|
|
|
assert(object_type != OBJECT_NONE);
|
|
assert(tpoint_id != OBJECT_NONE);
|
|
|
|
if (g_trace_flags == NULL) {
|
|
SPDK_ERRLOG("trace is not initialized\n");
|
|
return;
|
|
}
|
|
|
|
/* We do not check whether a tpoint_id exists here, because
|
|
* there is no order in which trace definitions are registered.
|
|
* This way we can create relations between tpoint and objects
|
|
* that will be declared later. */
|
|
tpoint = &g_trace_flags->tpoint[tpoint_id];
|
|
for (i = 0; i < SPDK_COUNTOF(tpoint->related_objects); ++i) {
|
|
if (tpoint->related_objects[i].object_type == OBJECT_NONE) {
|
|
tpoint->related_objects[i].object_type = object_type;
|
|
tpoint->related_objects[i].arg_index = arg_index;
|
|
return;
|
|
}
|
|
}
|
|
SPDK_ERRLOG("Unable to register new relation for tpoint %" PRIu16 ", object %" PRIu8 "\n",
|
|
tpoint_id, object_type);
|
|
}
|
|
|
|
void
|
|
spdk_trace_add_register_fn(struct spdk_trace_register_fn *reg_fn)
|
|
{
|
|
struct spdk_trace_register_fn *_reg_fn;
|
|
|
|
if (reg_fn->name == NULL) {
|
|
SPDK_ERRLOG("missing name for registering spdk trace tpoint group\n");
|
|
assert(false);
|
|
return;
|
|
}
|
|
|
|
if (strcmp(reg_fn->name, "all") == 0) {
|
|
SPDK_ERRLOG("illegal name (%s) for tpoint group\n", reg_fn->name);
|
|
assert(false);
|
|
return;
|
|
}
|
|
|
|
/* Ensure that no trace point group IDs and names are ever duplicated */
|
|
for (_reg_fn = g_reg_fn_head; _reg_fn; _reg_fn = _reg_fn->next) {
|
|
if (reg_fn->tgroup_id == _reg_fn->tgroup_id) {
|
|
SPDK_ERRLOG("group %d, %s has duplicate tgroup_id with %s\n",
|
|
reg_fn->tgroup_id, reg_fn->name, _reg_fn->name);
|
|
assert(false);
|
|
return;
|
|
}
|
|
|
|
if (strcmp(reg_fn->name, _reg_fn->name) == 0) {
|
|
SPDK_ERRLOG("name %s is duplicated between groups with ids %d and %d\n",
|
|
reg_fn->name, reg_fn->tgroup_id, _reg_fn->tgroup_id);
|
|
assert(false);
|
|
return;
|
|
}
|
|
}
|
|
|
|
/* Arrange trace registration in order on tgroup_id */
|
|
if (g_reg_fn_head == NULL || reg_fn->tgroup_id < g_reg_fn_head->tgroup_id) {
|
|
reg_fn->next = g_reg_fn_head;
|
|
g_reg_fn_head = reg_fn;
|
|
return;
|
|
}
|
|
|
|
for (_reg_fn = g_reg_fn_head; _reg_fn; _reg_fn = _reg_fn->next) {
|
|
if (_reg_fn->next == NULL || reg_fn->tgroup_id < _reg_fn->next->tgroup_id) {
|
|
reg_fn->next = _reg_fn->next;
|
|
_reg_fn->next = reg_fn;
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
spdk_trace_flags_init(void)
|
|
{
|
|
struct spdk_trace_register_fn *reg_fn;
|
|
|
|
reg_fn = g_reg_fn_head;
|
|
while (reg_fn) {
|
|
reg_fn->reg_fn();
|
|
reg_fn = reg_fn->next;
|
|
}
|
|
}
|