2bc134eb4b
When sending a fused compare and write command, we pass a callback bdev_nvme_comparev_and_writev_done that we expect to be called twice before marking the io as completed. In order to detect if a call to bdev_nvme_comparev_and_writev_done is the first or the second one, we currently rely on the opcode in cdw0. However, cdw0 may be set to 0, especially when aborting the command. This may cause use-after-free issues and this may call the user callbacks twice instead of once. Use a bit in the nvme_bdev_io instead to keep track of the number of calls to bdev_nvme_comparev_and_writev_done. Signed-off-by: Alex Michon <amichon@kalrayinc.com> Change-Id: I0474329e87648e44b08998d0552b2a9dd5d34ac2 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12180 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> |
||
|---|---|---|
| .. | ||
| bdev_zone.c | ||
| bdev.c | ||
| compress.c | ||
| crypto.c | ||
| gpt | ||
| mt | ||
| nvme | ||
| part.c | ||
| pmem | ||
| raid | ||
| scsi_nvme.c | ||
| vbdev_lvol.c | ||
| vbdev_zone_block.c | ||
| Makefile | ||