The NVMe over Fabrics target library now exposes a simple function call that polls the acceptor once, and the application handles registration of the poller. Also rename the transport function pointers related to the acceptor so they better reflect their purpose. Change-Id: I5fa0d516586bf17e73afeb88ff3c2d5b0d46794d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
532 lines
13 KiB
C
532 lines
13 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <ctype.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <strings.h>
|
|
|
|
#include <rte_config.h>
|
|
#include <rte_lcore.h>
|
|
|
|
#include "conf.h"
|
|
#include "nvmf/subsystem.h"
|
|
#include "nvmf/transport.h"
|
|
#include "spdk/conf.h"
|
|
#include "spdk/log.h"
|
|
|
|
#define MAX_LISTEN_ADDRESSES 255
|
|
#define MAX_HOSTS 255
|
|
|
|
#define PORTNUMSTRLEN 32
|
|
|
|
struct spdk_nvmf_probe_ctx {
|
|
struct spdk_nvmf_subsystem *subsystem;
|
|
bool any;
|
|
bool found;
|
|
uint32_t domain;
|
|
uint32_t bus;
|
|
uint32_t device;
|
|
uint32_t function;
|
|
};
|
|
|
|
#define SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_DEFAULT 4
|
|
#define SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_MIN 2
|
|
#define SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_MAX 1024
|
|
|
|
#define SPDK_NVMF_CONFIG_QUEUE_DEPTH_DEFAULT 128
|
|
#define SPDK_NVMF_CONFIG_QUEUE_DEPTH_MIN 16
|
|
#define SPDK_NVMF_CONFIG_QUEUE_DEPTH_MAX 1024
|
|
|
|
#define SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_DEFAULT 4096
|
|
#define SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_MIN 4096
|
|
#define SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_MAX 131072
|
|
|
|
#define SPDK_NVMF_CONFIG_MAX_IO_SIZE_DEFAULT 131072
|
|
#define SPDK_NVMF_CONFIG_MAX_IO_SIZE_MIN 4096
|
|
#define SPDK_NVMF_CONFIG_MAX_IO_SIZE_MAX 131072
|
|
|
|
struct spdk_nvmf_tgt_conf g_spdk_nvmf_tgt_conf;
|
|
|
|
static int
|
|
spdk_add_nvmf_discovery_subsystem(void)
|
|
{
|
|
struct spdk_nvmf_subsystem *subsystem;
|
|
|
|
subsystem = nvmf_create_subsystem(0, SPDK_NVMF_DISCOVERY_NQN, SPDK_NVMF_SUBTYPE_DISCOVERY,
|
|
rte_get_master_lcore());
|
|
if (subsystem == NULL) {
|
|
SPDK_ERRLOG("Failed creating discovery nvmf library subsystem\n");
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_parse_nvmf_tgt(void)
|
|
{
|
|
struct spdk_conf_section *sp;
|
|
int max_queue_depth;
|
|
int max_queues_per_sess;
|
|
int in_capsule_data_size;
|
|
int max_io_size;
|
|
int acceptor_lcore;
|
|
int rc;
|
|
|
|
sp = spdk_conf_find_section(NULL, "Nvmf");
|
|
if (sp == NULL) {
|
|
SPDK_ERRLOG("No Nvmf section in configuration file.\n");
|
|
return -1;
|
|
}
|
|
|
|
max_queue_depth = spdk_conf_section_get_intval(sp, "MaxQueueDepth");
|
|
if (max_queue_depth < 0) {
|
|
max_queue_depth = SPDK_NVMF_CONFIG_QUEUE_DEPTH_DEFAULT;
|
|
}
|
|
max_queue_depth = nvmf_max(max_queue_depth, SPDK_NVMF_CONFIG_QUEUE_DEPTH_MIN);
|
|
max_queue_depth = nvmf_min(max_queue_depth, SPDK_NVMF_CONFIG_QUEUE_DEPTH_MAX);
|
|
|
|
max_queues_per_sess = spdk_conf_section_get_intval(sp, "MaxQueuesPerSession");
|
|
if (max_queues_per_sess < 0) {
|
|
max_queues_per_sess = SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_DEFAULT;
|
|
}
|
|
max_queues_per_sess = nvmf_max(max_queues_per_sess, SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_MIN);
|
|
max_queues_per_sess = nvmf_min(max_queues_per_sess, SPDK_NVMF_CONFIG_QUEUES_PER_SESSION_MAX);
|
|
|
|
in_capsule_data_size = spdk_conf_section_get_intval(sp, "InCapsuleDataSize");
|
|
if (in_capsule_data_size < 0) {
|
|
in_capsule_data_size = SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_DEFAULT;
|
|
} else if ((in_capsule_data_size % 16) != 0) {
|
|
SPDK_ERRLOG("InCapsuleDataSize must be a multiple of 16\n");
|
|
return -1;
|
|
}
|
|
in_capsule_data_size = nvmf_max(in_capsule_data_size, SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_MIN);
|
|
in_capsule_data_size = nvmf_min(in_capsule_data_size, SPDK_NVMF_CONFIG_IN_CAPSULE_DATA_SIZE_MAX);
|
|
|
|
max_io_size = spdk_conf_section_get_intval(sp, "MaxIOSize");
|
|
if (max_io_size < 0) {
|
|
max_io_size = SPDK_NVMF_CONFIG_MAX_IO_SIZE_DEFAULT;
|
|
} else if ((max_io_size % 4096) != 0) {
|
|
SPDK_ERRLOG("MaxIOSize must be a multiple of 4096\n");
|
|
return -1;
|
|
}
|
|
max_io_size = nvmf_max(max_io_size, SPDK_NVMF_CONFIG_MAX_IO_SIZE_MIN);
|
|
max_io_size = nvmf_min(max_io_size, SPDK_NVMF_CONFIG_MAX_IO_SIZE_MAX);
|
|
|
|
acceptor_lcore = spdk_conf_section_get_intval(sp, "AcceptorCore");
|
|
if (acceptor_lcore < 0) {
|
|
acceptor_lcore = rte_lcore_id();
|
|
}
|
|
g_spdk_nvmf_tgt_conf.acceptor_lcore = acceptor_lcore;
|
|
|
|
rc = nvmf_tgt_init(max_queue_depth, max_queues_per_sess, in_capsule_data_size, max_io_size);
|
|
if (rc != 0) {
|
|
SPDK_ERRLOG("nvmf_tgt_init() failed\n");
|
|
return rc;
|
|
}
|
|
|
|
rc = spdk_add_nvmf_discovery_subsystem();
|
|
if (rc != 0) {
|
|
SPDK_ERRLOG("spdk_add_nvmf_discovery_subsystem failed\n");
|
|
return rc;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_parse_addr(char *listen_addr, char **host, char **port)
|
|
{
|
|
int n, len;
|
|
const char *p, *q;
|
|
|
|
if (listen_addr == NULL) {
|
|
SPDK_ERRLOG("Invalid listen addr for Fabric Interface (NULL)\n");
|
|
return -1;
|
|
}
|
|
|
|
*host = NULL;
|
|
*port = NULL;
|
|
|
|
if (listen_addr[0] == '[') {
|
|
/* IPv6 */
|
|
p = strchr(listen_addr + 1, ']');
|
|
if (p == NULL) {
|
|
return -1;
|
|
}
|
|
p++;
|
|
n = p - listen_addr;
|
|
*host = calloc(1, n + 1);
|
|
if (!*host) {
|
|
return -1;
|
|
}
|
|
memcpy(*host, listen_addr, n);
|
|
(*host)[n] = '\0';
|
|
if (p[0] == '\0') {
|
|
*port = calloc(1, PORTNUMSTRLEN);
|
|
if (!*port) {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
snprintf(*port, PORTNUMSTRLEN, "%d", SPDK_NVMF_DEFAULT_SIN_PORT);
|
|
} else {
|
|
if (p[0] != ':') {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
q = strchr(listen_addr, '@');
|
|
if (q == NULL) {
|
|
q = listen_addr + strlen(listen_addr);
|
|
}
|
|
len = q - p - 1;
|
|
|
|
*port = calloc(1, len + 1);
|
|
if (!*port) {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
memcpy(*port, p + 1, len);
|
|
}
|
|
} else {
|
|
/* IPv4 */
|
|
p = strchr(listen_addr, ':');
|
|
if (p == NULL) {
|
|
p = listen_addr + strlen(listen_addr);
|
|
}
|
|
n = p - listen_addr;
|
|
*host = calloc(1, n + 1);
|
|
if (!*host) {
|
|
return -1;
|
|
}
|
|
memcpy(*host, listen_addr, n);
|
|
(*host)[n] = '\0';
|
|
if (p[0] == '\0') {
|
|
*port = calloc(1, PORTNUMSTRLEN);
|
|
if (!*port) {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
snprintf(*port, PORTNUMSTRLEN, "%d", SPDK_NVMF_DEFAULT_SIN_PORT);
|
|
} else {
|
|
if (p[0] != ':') {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
q = strchr(listen_addr, '@');
|
|
if (q == NULL) {
|
|
q = listen_addr + strlen(listen_addr);
|
|
}
|
|
|
|
if (q == p) {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
|
|
len = q - p - 1;
|
|
*port = calloc(1, len + 1);
|
|
if (!*port) {
|
|
free(*host);
|
|
return -1;
|
|
}
|
|
memcpy(*port, p + 1, len);
|
|
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static bool
|
|
probe_cb(void *cb_ctx, struct spdk_pci_device *dev, struct spdk_nvme_ctrlr_opts *opts)
|
|
{
|
|
struct spdk_nvmf_probe_ctx *ctx = cb_ctx;
|
|
uint16_t found_domain = spdk_pci_device_get_domain(dev);
|
|
uint8_t found_bus = spdk_pci_device_get_bus(dev);
|
|
uint8_t found_dev = spdk_pci_device_get_dev(dev);
|
|
uint8_t found_func = spdk_pci_device_get_func(dev);
|
|
|
|
if (ctx->any && !ctx->found) {
|
|
ctx->found = true;
|
|
return true;
|
|
}
|
|
|
|
if (found_domain == ctx->domain &&
|
|
found_bus == ctx->bus &&
|
|
found_dev == ctx->device &&
|
|
found_func == ctx->function) {
|
|
if (!spdk_pci_device_has_non_uio_driver(dev)) {
|
|
return true;
|
|
}
|
|
SPDK_ERRLOG("Requested device is still bound to the kernel. Unbind your NVMe devices first.\n");
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
static void
|
|
attach_cb(void *cb_ctx, struct spdk_pci_device *dev, struct spdk_nvme_ctrlr *ctrlr,
|
|
const struct spdk_nvme_ctrlr_opts *opts)
|
|
{
|
|
struct spdk_nvmf_probe_ctx *ctx = cb_ctx;
|
|
uint16_t found_domain = spdk_pci_device_get_domain(dev);
|
|
uint8_t found_bus = spdk_pci_device_get_bus(dev);
|
|
uint8_t found_dev = spdk_pci_device_get_dev(dev);
|
|
uint8_t found_func = spdk_pci_device_get_func(dev);
|
|
int rc;
|
|
|
|
SPDK_NOTICELOG("Attaching NVMe device %x:%x:%x.%x to subsystem %s\n",
|
|
found_domain, found_bus, found_dev, found_func, ctx->subsystem->subnqn);
|
|
|
|
rc = nvmf_subsystem_add_ctrlr(ctx->subsystem, ctrlr);
|
|
if (rc < 0) {
|
|
SPDK_ERRLOG("Failed to add controller to subsystem\n");
|
|
}
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_validate_nqn(const char *nqn)
|
|
{
|
|
size_t len;
|
|
|
|
len = strlen(nqn);
|
|
if (len > SPDK_NVMF_NQN_MAX_LEN) {
|
|
SPDK_ERRLOG("Invalid NQN \"%s\": length %zu > max %d\n", nqn, len, SPDK_NVMF_NQN_MAX_LEN);
|
|
return -1;
|
|
}
|
|
|
|
if (strncasecmp(nqn, "nqn.", 4) != 0) {
|
|
SPDK_ERRLOG("Invalid NQN \"%s\": NQN must begin with \"nqn.\".\n", nqn);
|
|
return -1;
|
|
}
|
|
|
|
/* yyyy-mm. */
|
|
if (!(isdigit(nqn[4]) && isdigit(nqn[5]) && isdigit(nqn[6]) && isdigit(nqn[7]) &&
|
|
nqn[8] == '-' && isdigit(nqn[9]) && isdigit(nqn[10]) && nqn[11] == '.')) {
|
|
SPDK_ERRLOG("Invalid date code in NQN \"%s\"\n", nqn);
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_allocate_lcore(uint64_t mask, uint32_t lcore)
|
|
{
|
|
uint32_t end;
|
|
|
|
if (lcore == 0) {
|
|
end = 0;
|
|
} else {
|
|
end = lcore - 1;
|
|
}
|
|
|
|
do {
|
|
if (((mask >> lcore) & 1U) == 1U) {
|
|
break;
|
|
}
|
|
lcore = (lcore + 1) % 64;
|
|
} while (lcore != end);
|
|
|
|
return lcore;
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_parse_subsystem(struct spdk_conf_section *sp)
|
|
{
|
|
const char *nqn, *mode;
|
|
struct spdk_nvmf_subsystem *subsystem;
|
|
int i, ret;
|
|
uint64_t mask;
|
|
int lcore = 0;
|
|
|
|
nqn = spdk_conf_section_get_val(sp, "NQN");
|
|
if (nqn == NULL) {
|
|
SPDK_ERRLOG("No NQN specified for Subsystem %d\n", sp->num);
|
|
return -1;
|
|
}
|
|
|
|
if (spdk_nvmf_validate_nqn(nqn) != 0) {
|
|
return -1;
|
|
}
|
|
|
|
/* Determine which core to assign to the subsystem */
|
|
mask = spdk_app_get_core_mask();
|
|
lcore = spdk_conf_section_get_intval(sp, "Core");
|
|
if (lcore < 0) {
|
|
lcore = 0;
|
|
for (i = 0; i < sp->num; i++) {
|
|
lcore = spdk_nvmf_allocate_lcore(mask, lcore);
|
|
lcore++;
|
|
}
|
|
}
|
|
lcore = spdk_nvmf_allocate_lcore(mask, lcore);
|
|
|
|
subsystem = nvmf_create_subsystem(sp->num, nqn, SPDK_NVMF_SUBTYPE_NVME, lcore);
|
|
if (subsystem == NULL) {
|
|
return -1;
|
|
}
|
|
|
|
mode = spdk_conf_section_get_val(sp, "Mode");
|
|
if (mode == NULL) {
|
|
nvmf_delete_subsystem(subsystem);
|
|
SPDK_ERRLOG("No Mode specified for Subsystem %d\n", sp->num);
|
|
return -1;
|
|
}
|
|
|
|
if (strcasecmp(mode, "Direct") == 0) {
|
|
subsystem->mode = NVMF_SUBSYSTEM_MODE_DIRECT;
|
|
} else if (strcasecmp(mode, "Virtual") == 0) {
|
|
nvmf_delete_subsystem(subsystem);
|
|
SPDK_ERRLOG("Virtual Subsystems are not yet supported.\n");
|
|
return -1;
|
|
} else {
|
|
nvmf_delete_subsystem(subsystem);
|
|
SPDK_ERRLOG("Invalid Subsystem mode: %s\n", mode);
|
|
return -1;
|
|
}
|
|
|
|
/* Parse Listen sections */
|
|
for (i = 0; i < MAX_LISTEN_ADDRESSES; i++) {
|
|
char *transport_name, *listen_addr;
|
|
char *traddr, *trsvc;
|
|
const struct spdk_nvmf_transport *transport;
|
|
|
|
transport_name = spdk_conf_section_get_nmval(sp, "Listen", i, 0);
|
|
listen_addr = spdk_conf_section_get_nmval(sp, "Listen", i, 1);
|
|
|
|
if (!transport_name || !listen_addr) {
|
|
break;
|
|
}
|
|
|
|
transport = spdk_nvmf_transport_get(transport_name);
|
|
if (transport == NULL) {
|
|
SPDK_ERRLOG("Unknown transport type '%s'\n", transport_name);
|
|
continue;
|
|
}
|
|
|
|
ret = spdk_nvmf_parse_addr(listen_addr, &traddr, &trsvc);
|
|
if (ret < 0) {
|
|
SPDK_ERRLOG("Unable to parse transport address '%s'\n", listen_addr);
|
|
continue;
|
|
}
|
|
|
|
spdk_nvmf_subsystem_add_listener(subsystem, transport, traddr, trsvc);
|
|
|
|
free(traddr);
|
|
free(trsvc);
|
|
}
|
|
|
|
/* Parse Host sections */
|
|
for (i = 0; i < MAX_HOSTS; i++) {
|
|
char *host_nqn;
|
|
|
|
host_nqn = spdk_conf_section_get_nval(sp, "Host", i);
|
|
if (!host_nqn) {
|
|
break;
|
|
}
|
|
|
|
spdk_nvmf_subsystem_add_host(subsystem, host_nqn);
|
|
}
|
|
|
|
if (subsystem->mode == NVMF_SUBSYSTEM_MODE_DIRECT) {
|
|
const char *bdf;
|
|
struct spdk_nvmf_probe_ctx ctx = { 0 };
|
|
|
|
/* Parse NVMe section */
|
|
bdf = spdk_conf_section_get_val(sp, "NVMe");
|
|
if (bdf == NULL) {
|
|
SPDK_ERRLOG("Subsystem %d: missing NVMe directive\n", sp->num);
|
|
nvmf_delete_subsystem(subsystem);
|
|
return -1;
|
|
}
|
|
|
|
ctx.subsystem = subsystem;
|
|
ctx.found = false;
|
|
if (strcmp(bdf, "*") == 0) {
|
|
ctx.any = true;
|
|
} else {
|
|
ret = sscanf(bdf, "%x:%x:%x.%x", &ctx.domain, &ctx.bus, &ctx.device, &ctx.function);
|
|
if (ret != 4) {
|
|
SPDK_ERRLOG("Invalid format for NVMe BDF: %s\n", bdf);
|
|
return -1;
|
|
}
|
|
ctx.any = false;
|
|
}
|
|
|
|
if (spdk_nvme_probe(&ctx, probe_cb, attach_cb, NULL)) {
|
|
SPDK_ERRLOG("One or more controllers failed in spdk_nvme_probe()\n");
|
|
}
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
spdk_nvmf_parse_subsystems(void)
|
|
{
|
|
int rc = 0;
|
|
struct spdk_conf_section *sp;
|
|
|
|
sp = spdk_conf_first_section(NULL);
|
|
while (sp != NULL) {
|
|
if (spdk_conf_section_match_prefix(sp, "Subsystem")) {
|
|
rc = spdk_nvmf_parse_subsystem(sp);
|
|
if (rc < 0) {
|
|
return -1;
|
|
}
|
|
}
|
|
sp = spdk_conf_next_section(sp);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
spdk_nvmf_parse_conf(void)
|
|
{
|
|
int rc;
|
|
|
|
/* NVMf section */
|
|
rc = spdk_nvmf_parse_nvmf_tgt();
|
|
if (rc < 0) {
|
|
return rc;
|
|
}
|
|
|
|
/* Subsystem sections */
|
|
rc = spdk_nvmf_parse_subsystems();
|
|
if (rc < 0) {
|
|
return rc;
|
|
}
|
|
|
|
return 0;
|
|
}
|