We face the checksum error when using idxd hardware in vector mode because we put fields of internal function in wrong union. When use vector crc32c operation, seed and chained functions and cb's will be used in the same time, so we should not put them in the same union. With this patch, we can fix the crc32c computing while using the vector mode with iov_count > 1. Signed-off-by: Ziye Yang <ziye.yang@intel.com> Change-Id: I7097b47294ffd5dcac7d7a83d583321a73dc50d2 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8213 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
163 lines
5.0 KiB
C
163 lines
5.0 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_INTERNAL_ACCEL_ENGINE_H
|
|
#define SPDK_INTERNAL_ACCEL_ENGINE_H
|
|
|
|
#include "spdk/stdinc.h"
|
|
|
|
#include "spdk/accel_engine.h"
|
|
#include "spdk/queue.h"
|
|
|
|
struct spdk_accel_task;
|
|
|
|
void spdk_accel_task_complete(struct spdk_accel_task *task, int status);
|
|
|
|
struct accel_io_channel {
|
|
struct spdk_accel_engine *engine;
|
|
struct spdk_io_channel *engine_ch;
|
|
void *task_pool_base;
|
|
TAILQ_HEAD(, spdk_accel_task) task_pool;
|
|
void *batch_pool_base;
|
|
TAILQ_HEAD(, spdk_accel_batch) batch_pool;
|
|
TAILQ_HEAD(, spdk_accel_batch) batches;
|
|
};
|
|
|
|
struct spdk_accel_batch {
|
|
/* Lists of commands in the batch. */
|
|
TAILQ_HEAD(, spdk_accel_task) hw_tasks;
|
|
TAILQ_HEAD(, spdk_accel_task) sw_tasks;
|
|
/* Specific to the batch task itself. */
|
|
int status;
|
|
uint32_t count;
|
|
spdk_accel_completion_cb cb_fn;
|
|
void *cb_arg;
|
|
struct accel_io_channel *accel_ch;
|
|
TAILQ_ENTRY(spdk_accel_batch) link;
|
|
};
|
|
|
|
enum accel_opcode {
|
|
ACCEL_OPCODE_MEMMOVE = 0,
|
|
ACCEL_OPCODE_MEMFILL = 1,
|
|
ACCEL_OPCODE_COMPARE = 2,
|
|
ACCEL_OPCODE_BATCH = 3,
|
|
ACCEL_OPCODE_CRC32C = 4,
|
|
ACCEL_OPCODE_DUALCAST = 5,
|
|
ACCEL_OPCODE_COPY_CRC32C = 6,
|
|
};
|
|
|
|
struct spdk_accel_task {
|
|
struct accel_io_channel *accel_ch;
|
|
struct spdk_accel_batch *batch;
|
|
spdk_accel_completion_cb cb_fn;
|
|
void *cb_arg;
|
|
struct {
|
|
spdk_accel_completion_cb cb_fn;
|
|
void *cb_arg;
|
|
} chained;
|
|
union {
|
|
struct {
|
|
struct iovec *iovs; /* iovs passed by the caller */
|
|
uint32_t iovcnt; /* iovcnt passed by the caller */
|
|
} v;
|
|
void *src;
|
|
};
|
|
union {
|
|
void *dst;
|
|
void *src2;
|
|
};
|
|
union {
|
|
void *dst2;
|
|
uint32_t seed;
|
|
uint64_t fill_pattern;
|
|
};
|
|
uint32_t *crc_dst;
|
|
enum accel_opcode op_code;
|
|
uint64_t nbytes;
|
|
TAILQ_ENTRY(spdk_accel_task) link;
|
|
uint8_t offload_ctx[0]; /* Not currently used. */
|
|
};
|
|
|
|
struct spdk_accel_engine {
|
|
uint64_t capabilities;
|
|
uint64_t (*get_capabilities)(void);
|
|
struct spdk_io_channel *(*get_io_channel)(void);
|
|
uint32_t (*batch_get_max)(struct spdk_io_channel *ch);
|
|
int (*submit_tasks)(struct spdk_io_channel *ch, struct spdk_accel_task *accel_task);
|
|
};
|
|
|
|
struct spdk_accel_module_if {
|
|
/** Initialization function for the module. Called by the spdk
|
|
* application during startup.
|
|
*
|
|
* Modules are required to define this function.
|
|
*/
|
|
int (*module_init)(void);
|
|
|
|
/** Finish function for the module. Called by the spdk application
|
|
* before the spdk application exits to perform any necessary cleanup.
|
|
*
|
|
* Modules are not required to define this function.
|
|
*/
|
|
void (*module_fini)(void *ctx);
|
|
|
|
/**
|
|
* Write Acceleration module configuration into provided JSON context.
|
|
*/
|
|
void (*write_config_json)(struct spdk_json_write_ctx *w);
|
|
|
|
/**
|
|
* Returns the allocation size required for the modules to use for context.
|
|
*/
|
|
size_t (*get_ctx_size)(void);
|
|
|
|
TAILQ_ENTRY(spdk_accel_module_if) tailq;
|
|
};
|
|
|
|
void spdk_accel_hw_engine_register(struct spdk_accel_engine *accel_engine);
|
|
void spdk_accel_module_list_add(struct spdk_accel_module_if *accel_module);
|
|
|
|
#define SPDK_ACCEL_MODULE_REGISTER(init_fn, fini_fn, config_json, ctx_size_fn) \
|
|
static struct spdk_accel_module_if init_fn ## _if = { \
|
|
.module_init = init_fn, \
|
|
.module_fini = fini_fn, \
|
|
.write_config_json = config_json, \
|
|
.get_ctx_size = ctx_size_fn, \
|
|
}; \
|
|
__attribute__((constructor)) static void init_fn ## _init(void) \
|
|
{ \
|
|
spdk_accel_module_list_add(&init_fn ## _if); \
|
|
}
|
|
|
|
#endif
|