resp->error is usually a JSON object, but it was printed as a string. For objects, resp->len was the number of fields in this object, definitely not a length of the string to print. There was usually just 3 characters printed with no newline. To print this object we should stringify it using our json_write library, so that's this patch does. Before: json_config.c: 192:rpc_client_poller: *ERROR*: error response: {"co (missing newline at the end) After: [2020-06-19 13:33:57.060869] json_config.c: 220:rpc_client_poller: *ERROR*: error response: { "code": -32601, "message": "Method not found" } [2020-06-19 13:33:57.061067] app.c: 714:spdk_app_stop: *WARNING*: spdk_app_stop'd on non-zero Change-Id: I5d7aeba2b972782f18b8da0141ed4bfd79833f80 Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2971 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> |
||
---|---|---|
.. | ||
app.c | ||
json_config.c | ||
Makefile | ||
reactor.c | ||
rpc.c | ||
spdk_event.map | ||
subsystem.c |