Session start callbacks have technically two ways of returning an error code: a) as the callback return value, e.g. return -1 b) via vhost_session_start_done(int rc) The former doesn't have any effect as that return value is not checked anywhere. It's only present because we wanted to use the same function signature as for the foreach_session() callbacks. It's going to be cleaned up in subsequent patches, but before that happens we have to fix vhost_nvme. With vhost_session_start_done(-1) called, DPDK will terminate the entire socket connection. Change-Id: Ib1eff17a67eef055b0dc89fa13d1fed2f8a1fbf0 Signed-off-by: Vitaliy Mysak <vitaliy.mysak@intel.com> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/467230 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> |
||
---|---|---|
.. | ||
Makefile | ||
rte_vhost_compat.c | ||
vhost_blk.c | ||
vhost_internal.h | ||
vhost_nvme.c | ||
vhost_rpc.c | ||
vhost_scsi.c | ||
vhost.c |