ebb89b20ca
We only detached the PCI device on the controller destruction, which happens just once - in the primary process, but secondary process needs the PCI detach as well. Requesting to hotremove the NVMe PCIe controller in secondary process is broken, because DPDK will still keep the device reference and won't allow SPDK to hotplug it again. Fix this by detaching the local PCI device whenever removing a secondary process from spdk_nvme_ctrlr. This does require an additional transport check in the generic NVMe layer, but I found it an overkill to create a multi-process transport abstraction just for this case. Change-Id: I812dc1c878ade5b149556806228a2afcb49f0b17 Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.gerrithub.io/431487 (master) Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/448364 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> |
||
|---|---|---|
| .. | ||
| nvme_ctrlr_cmd.c | ||
| nvme_ctrlr_ocssd_cmd.c | ||
| nvme_ctrlr.c | ||
| nvme_ns_cmd.c | ||
| nvme_ns_ocssd_cmd.c | ||
| nvme_ns.c | ||
| nvme_pcie.c | ||
| nvme_qpair.c | ||
| nvme_quirks.c | ||
| nvme_rdma.c | ||
| nvme.c | ||
| Makefile | ||