The last parameter xfer_len of spdk_bdev_scsi_read is not used, and of spdk_bdev_scsi_write is used only to check task->transfer_len. Hence remove the last parameter xfer_len from spdk_bdev_scsi_read/write and extract the check operation from spdk_bdev_scsi_write and insert it into spdk_bdev_scsi_read_write. Additionally, remove a debug log because xfer_len is not passed to spdk_bdev_scsi_write anymore. Hopufully, this will not degrade any maintainability. On top of this, factoring out the operation to convert byte to block in spdk_bdev_scsi_read/write be done. Change-Id: I35faca269a9c4a7f15d27e8e61b6a1b809a36b3f Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-on: https://review.gerrithub.io/c/444776 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> |
||
---|---|---|
.. | ||
dev.c | ||
lun.c | ||
Makefile | ||
port.c | ||
scsi_bdev.c | ||
scsi_internal.h | ||
scsi_rpc.c | ||
scsi.c | ||
task.c |