037c8b01a1
If blob_freeze_io() is called twice in a row, and the second time occurs before the for_each_channel for the first completes, the second caller will receive its callback too soon. Instead just simplify the whole process, always do the for_each_channel and don't try to optimize it at all. These are infrequent operations - correctness and simplicity are in order. A few additional changes: 1) Make same changes for unfreeze path. 2) Add blob_verify_md_op() calls, just to be sure these are only called from md_thread. This was already checked in calling functions, but as these functions get called from new code paths (i.e. esnap clones) it can't hurt to add additional checks. 3) Add unit test that failed with original code, but passes with this patch. Fixes issue #2935. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ibefba554547ddf3e26aaabfa4288c8073d3c04ff Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17148 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-by: Mike Gerdts <mgerdts@nvidia.com> Community-CI: Mellanox Build Bot |
||
|---|---|---|
| .. | ||
| blob_bs_dev.c | ||
| blobstore.c | ||
| blobstore.h | ||
| Makefile | ||
| request.c | ||
| request.h | ||
| spdk_blob.map | ||
| zeroes.c | ||