0064713871
The bdevio test app has some test cases verifying that write zeroes commands are handled correctly, but using knowledge of the ZERO_BUFFER_SIZE that the bdev library uses for splitting larger write zeroes commands. Instead of hardcoding that 1MB value in bdevio.c, have bdevio.c use ZERO_BUFFER_SIZE directly instead. But this requires moving ZERO_BUFFER_SIZE into bdev_internal.h and having bdevio.c include that file. We do this instead of putting ZERO_BUFFER_SIZE in the public API because we don't want users to make any kind of dependencies on this value. While here, also rename the tests that are using this value, so that the test names don't include any reference to the specific size of this bdev-internal zero buffer size. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ia29d92a706cb1f86b4c29374dc2a9beccf679208 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12383 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com> Reviewed-by: Shuhei Matsumoto <smatsumoto@nvidia.com>
53 lines
2.1 KiB
C
53 lines
2.1 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright (c) Intel Corporation.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SPDK_BDEV_INTERNAL_H
|
|
#define SPDK_BDEV_INTERNAL_H
|
|
|
|
#include "spdk/bdev.h"
|
|
|
|
#define ZERO_BUFFER_SIZE 0x100000
|
|
|
|
struct spdk_bdev;
|
|
struct spdk_bdev_io;
|
|
struct spdk_bdev_channel;
|
|
|
|
struct spdk_bdev_io *bdev_channel_get_io(struct spdk_bdev_channel *channel);
|
|
|
|
void bdev_io_init(struct spdk_bdev_io *bdev_io, struct spdk_bdev *bdev, void *cb_arg,
|
|
spdk_bdev_io_completion_cb cb);
|
|
|
|
void bdev_io_submit(struct spdk_bdev_io *bdev_io);
|
|
|
|
#endif /* SPDK_BDEV_INTERNAL_H */
|