/*- * BSD LICENSE * * Copyright (c) Intel Corporation. * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * * * Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in * the documentation and/or other materials provided with the * distribution. * * Neither the name of Intel Corporation nor the names of its * contributors may be used to endorse or promote products derived * from this software without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ #include "spdk/stdinc.h" #include "common/lib/test_env.c" #include "spdk_cunit.h" #include "iscsi/conn.c" #include "spdk_internal/mock.h" SPDK_LOG_REGISTER_COMPONENT("iscsi", SPDK_LOG_ISCSI) #define DMIN32(A,B) ((uint32_t) ((uint32_t)(A) > (uint32_t)(B) ? (uint32_t)(B) : (uint32_t)(A))) struct spdk_iscsi_globals g_spdk_iscsi; static TAILQ_HEAD(, spdk_iscsi_task) g_ut_read_tasks = TAILQ_HEAD_INITIALIZER(g_ut_read_tasks); DEFINE_STUB(spdk_app_get_shm_id, int, (void), 0); DEFINE_STUB(spdk_env_get_current_core, uint32_t, (void), 0); DEFINE_STUB(spdk_env_get_first_core, uint32_t, (void), 0); DEFINE_STUB(spdk_env_get_last_core, uint32_t, (void), 0); DEFINE_STUB(spdk_env_get_next_core, uint32_t, (uint32_t prev_core), 0); DEFINE_STUB(spdk_event_allocate, struct spdk_event *, (uint32_t lcore, spdk_event_fn fn, void *arg1, void *arg2), NULL); DEFINE_STUB_V(spdk_event_call, (struct spdk_event *event)); DEFINE_STUB(spdk_sock_getaddr, int, (struct spdk_sock *sock, char *saddr, int slen, uint16_t *sport, char *caddr, int clen, uint16_t *cport), 0); int spdk_sock_close(struct spdk_sock **sock) { *sock = NULL; return 0; } DEFINE_STUB(spdk_sock_recv, ssize_t, (struct spdk_sock *sock, void *buf, size_t len), 0); DEFINE_STUB(spdk_sock_readv, ssize_t, (struct spdk_sock *sock, struct iovec *iov, int iovcnt), 0); DEFINE_STUB(spdk_sock_writev, ssize_t, (struct spdk_sock *sock, struct iovec *iov, int iovcnt), 0); DEFINE_STUB(spdk_sock_set_recvlowat, int, (struct spdk_sock *s, int nbytes), 0); DEFINE_STUB(spdk_sock_set_recvbuf, int, (struct spdk_sock *sock, int sz), 0); DEFINE_STUB(spdk_sock_set_sendbuf, int, (struct spdk_sock *sock, int sz), 0); DEFINE_STUB(spdk_sock_group_add_sock, int, (struct spdk_sock_group *group, struct spdk_sock *sock, spdk_sock_cb cb_fn, void *cb_arg), 0); DEFINE_STUB(spdk_sock_group_remove_sock, int, (struct spdk_sock_group *group, struct spdk_sock *sock), 0); DEFINE_STUB_V(spdk_scsi_task_put, (struct spdk_scsi_task *task)); DEFINE_STUB(spdk_scsi_dev_get_lun, struct spdk_scsi_lun *, (struct spdk_scsi_dev *dev, int lun_id), NULL); DEFINE_STUB(spdk_scsi_dev_has_pending_tasks, bool, (const struct spdk_scsi_dev *dev), true); DEFINE_STUB(spdk_scsi_lun_open, int, (struct spdk_scsi_lun *lun, spdk_scsi_remove_cb_t hotremove_cb, void *hotremove_ctx, struct spdk_scsi_desc **desc), 0); DEFINE_STUB_V(spdk_scsi_lun_close, (struct spdk_scsi_desc *desc)); DEFINE_STUB(spdk_scsi_lun_allocate_io_channel, int, (struct spdk_scsi_desc *desc), 0); DEFINE_STUB_V(spdk_scsi_lun_free_io_channel, (struct spdk_scsi_desc *desc)); DEFINE_STUB(spdk_scsi_lun_get_id, int, (const struct spdk_scsi_lun *lun), 0); DEFINE_STUB(spdk_scsi_port_get_name, const char *, (const struct spdk_scsi_port *port), NULL); void spdk_scsi_task_copy_status(struct spdk_scsi_task *dst, struct spdk_scsi_task *src) { dst->status = src->status; } DEFINE_STUB_V(spdk_put_pdu, (struct spdk_iscsi_pdu *pdu)); DEFINE_STUB_V(spdk_iscsi_param_free, (struct iscsi_param *params)); DEFINE_STUB(spdk_iscsi_conn_params_init, int, (struct iscsi_param **params), 0); DEFINE_STUB_V(spdk_clear_all_transfer_task, (struct spdk_iscsi_conn *conn, struct spdk_scsi_lun *lun, struct spdk_iscsi_pdu *pdu)); DEFINE_STUB(spdk_iscsi_build_iovs, int, (struct spdk_iscsi_conn *conn, struct iovec *iov, int num_iovs, struct spdk_iscsi_pdu *pdu, uint32_t *mapped_length), 0); DEFINE_STUB(spdk_iscsi_is_deferred_free_pdu, bool, (struct spdk_iscsi_pdu *pdu), false); DEFINE_STUB_V(spdk_iscsi_task_response, (struct spdk_iscsi_conn *conn, struct spdk_iscsi_task *task)); DEFINE_STUB_V(spdk_iscsi_task_mgmt_response, (struct spdk_iscsi_conn *conn, struct spdk_iscsi_task *task)); DEFINE_STUB_V(spdk_iscsi_send_nopin, (struct spdk_iscsi_conn *conn)); DEFINE_STUB(spdk_iscsi_execute, int, (struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu *pdu), 0); DEFINE_STUB_V(spdk_del_transfer_task, (struct spdk_iscsi_conn *conn, uint32_t task_tag)); DEFINE_STUB(spdk_iscsi_conn_handle_queued_datain_tasks, int, (struct spdk_iscsi_conn *conn), 0); DEFINE_STUB(spdk_iscsi_read_pdu, int, (struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu **_pdu), 0); DEFINE_STUB_V(spdk_free_sess, (struct spdk_iscsi_sess *sess)); DEFINE_STUB(spdk_iscsi_tgt_node_cleanup_luns, int, (struct spdk_iscsi_conn *conn, struct spdk_iscsi_tgt_node *target), 0); DEFINE_STUB(spdk_iscsi_pdu_calc_header_digest, uint32_t, (struct spdk_iscsi_pdu *pdu), 0); DEFINE_STUB(spdk_iscsi_pdu_calc_data_digest, uint32_t, (struct spdk_iscsi_pdu *pdu), 0); DEFINE_STUB_V(spdk_shutdown_iscsi_conns_done, (void)); static struct spdk_iscsi_task * ut_conn_task_get(struct spdk_iscsi_task *parent) { struct spdk_iscsi_task *task; task = calloc(1, sizeof(*task)); SPDK_CU_ASSERT_FATAL(task != NULL); if (parent) { task->parent = parent; } return task; } static void ut_conn_create_read_tasks(int transfer_len) { struct spdk_iscsi_task *task, *subtask; int32_t remaining_size = 0; task = ut_conn_task_get(NULL); task->scsi.transfer_len = transfer_len; task->scsi.offset = 0; task->scsi.length = DMIN32(SPDK_BDEV_LARGE_BUF_MAX_SIZE, task->scsi.transfer_len); task->scsi.status = SPDK_SCSI_STATUS_GOOD; remaining_size = task->scsi.transfer_len - task->scsi.length; task->current_datain_offset = 0; if (remaining_size == 0) { TAILQ_INSERT_TAIL(&g_ut_read_tasks, task, link); return; } while (1) { if (task->current_datain_offset == 0) { task->current_datain_offset = task->scsi.length; TAILQ_INSERT_TAIL(&g_ut_read_tasks, task, link); continue; } if (task->current_datain_offset < task->scsi.transfer_len) { remaining_size = task->scsi.transfer_len - task->current_datain_offset; subtask = ut_conn_task_get(task); subtask->scsi.offset = task->current_datain_offset; subtask->scsi.length = DMIN32(SPDK_BDEV_LARGE_BUF_MAX_SIZE, remaining_size); subtask->scsi.status = SPDK_SCSI_STATUS_GOOD; task->current_datain_offset += subtask->scsi.length; TAILQ_INSERT_TAIL(&g_ut_read_tasks, subtask, link); } if (task->current_datain_offset == task->scsi.transfer_len) { break; } } } static void read_task_split_in_order_case(void) { struct spdk_iscsi_task *primary, *task, *tmp; ut_conn_create_read_tasks(SPDK_BDEV_LARGE_BUF_MAX_SIZE * 8); TAILQ_FOREACH(task, &g_ut_read_tasks, link) { primary = spdk_iscsi_task_get_primary(task); process_read_task_completion(NULL, task, primary); } primary = TAILQ_FIRST(&g_ut_read_tasks); SPDK_CU_ASSERT_FATAL(primary != NULL); if (primary != NULL) { CU_ASSERT(primary->bytes_completed == primary->scsi.transfer_len); } TAILQ_FOREACH_SAFE(task, &g_ut_read_tasks, link, tmp) { TAILQ_REMOVE(&g_ut_read_tasks, task, link); free(task); } CU_ASSERT(TAILQ_EMPTY(&g_ut_read_tasks)); } static void propagate_scsi_error_status_for_split_read_tasks(void) { struct spdk_iscsi_task primary, task1, task2, task3, task4, task5, task6; memset(&primary, 0, sizeof(struct spdk_iscsi_task)); primary.scsi.length = 512; primary.scsi.status = SPDK_SCSI_STATUS_GOOD; primary.rsp_scsi_status = SPDK_SCSI_STATUS_GOOD; TAILQ_INIT(&primary.subtask_list); memset(&task1, 0, sizeof(struct spdk_iscsi_task)); task1.scsi.offset = 512; task1.scsi.length = 512; task1.scsi.status = SPDK_SCSI_STATUS_GOOD; memset(&task2, 0, sizeof(struct spdk_iscsi_task)); task2.scsi.offset = 512 * 2; task2.scsi.length = 512; task2.scsi.status = SPDK_SCSI_STATUS_CHECK_CONDITION; memset(&task3, 0, sizeof(struct spdk_iscsi_task)); task3.scsi.offset = 512 * 3; task3.scsi.length = 512; task3.scsi.status = SPDK_SCSI_STATUS_GOOD; memset(&task4, 0, sizeof(struct spdk_iscsi_task)); task4.scsi.offset = 512 * 4; task4.scsi.length = 512; task4.scsi.status = SPDK_SCSI_STATUS_GOOD; memset(&task5, 0, sizeof(struct spdk_iscsi_task)); task5.scsi.offset = 512 * 5; task5.scsi.length = 512; task5.scsi.status = SPDK_SCSI_STATUS_GOOD; memset(&task6, 0, sizeof(struct spdk_iscsi_task)); task6.scsi.offset = 512 * 6; task6.scsi.length = 512; task6.scsi.status = SPDK_SCSI_STATUS_GOOD; /* task2 has check condition status, and verify if the check condition * status is propagated to remaining tasks correctly when these tasks complete * by the following order, task4, task3, task2, task1, primary, task5, and task6. */ process_read_task_completion(NULL, &task4, &primary); process_read_task_completion(NULL, &task3, &primary); process_read_task_completion(NULL, &task2, &primary); process_read_task_completion(NULL, &task1, &primary); process_read_task_completion(NULL, &primary, &primary); process_read_task_completion(NULL, &task5, &primary); process_read_task_completion(NULL, &task6, &primary); CU_ASSERT(primary.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task1.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task2.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task3.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task4.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task5.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(task6.scsi.status == SPDK_SCSI_STATUS_CHECK_CONDITION); CU_ASSERT(TAILQ_EMPTY(&primary.subtask_list)); } int main(int argc, char **argv) { CU_pSuite suite = NULL; unsigned int num_failures; if (CU_initialize_registry() != CUE_SUCCESS) { return CU_get_error(); } suite = CU_add_suite("conn_suite", NULL, NULL); if (suite == NULL) { CU_cleanup_registry(); return CU_get_error(); } if ( CU_add_test(suite, "read task split in order", read_task_split_in_order_case) == NULL || CU_add_test(suite, "propagate_scsi_error_status_for_split_read_tasks", propagate_scsi_error_status_for_split_read_tasks) == NULL ) { CU_cleanup_registry(); return CU_get_error(); } CU_basic_set_mode(CU_BRM_VERBOSE); CU_basic_run_tests(); num_failures = CU_get_number_of_failures(); CU_cleanup_registry(); return num_failures; }