ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iSCSI: change return value of spdk_iscsi_conn_free_tasks

Browse Source 
We need to return -1, when there is still tasks. From the
usage, return 1 is wrong.

Change-Id: Ibf1b53e0be92818c73590c0b4211d34332073c74
Signed-off-by: Ziye Yang <ziye.yang@intel.com>
This commit is contained in:
Ziye Yang 2016-09-27 14:25:42 +08:00 committed by Daniel Verkamp
parent 634786e583
commit ff38547d80
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/iscsi/conn.c
View File

@ -420,16 +420,18 @@ static int spdk_iscsi_conn_free_tasks(struct spdk_iscsi_conn *conn)
while (!TAILQ_EMPTY(&conn->write_pdu_list)) { while (!TAILQ_EMPTY(&conn->write_pdu_list)) {
pdu = TAILQ_FIRST(&conn->write_pdu_list); pdu = TAILQ_FIRST(&conn->write_pdu_list);
TAILQ_REMOVE(&conn->write_pdu_list, pdu, tailq); TAILQ_REMOVE(&conn->write_pdu_list, pdu, tailq);
if (pdu->task) if (pdu->task) {
spdk_iscsi_task_put(pdu->task); spdk_iscsi_task_put(pdu->task);
}
spdk_put_pdu(pdu); spdk_put_pdu(pdu);
} }
while (!TAILQ_EMPTY(&conn->snack_pdu_list)) { while (!TAILQ_EMPTY(&conn->snack_pdu_list)) {
pdu = TAILQ_FIRST(&conn->snack_pdu_list); pdu = TAILQ_FIRST(&conn->snack_pdu_list);
TAILQ_REMOVE(&conn->snack_pdu_list, pdu, tailq); TAILQ_REMOVE(&conn->snack_pdu_list, pdu, tailq);
if (pdu->task) if (pdu->task) {
spdk_iscsi_task_put(pdu->task); spdk_iscsi_task_put(pdu->task);
}
spdk_put_pdu(pdu); spdk_put_pdu(pdu);
} }
@ -442,7 +444,7 @@ static int spdk_iscsi_conn_free_tasks(struct spdk_iscsi_conn *conn)
} }
if (conn->pending_task_cnt) if (conn->pending_task_cnt)
return 1; return -1;
return 0; return 0;