From fce846647735caf7f8ac8cdb2ddd8891dd222f96 Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Mon, 8 Jan 2018 12:44:48 +0100 Subject: [PATCH] scsi/lun: fix segfault on sending mgmt task to inexistent lun spdk_scsi_lun_complete_mgmt_task can't be called with lun == NULL, as it deliberately dereferences it. Change-Id: Idf9b100b66cdc7fdfe2011fb7f9b2477651f1e8c Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/393912 Tested-by: SPDK Automated Test System Reviewed-by: Jim Harris Reviewed-by: --- lib/scsi/lun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/scsi/lun.c b/lib/scsi/lun.c index 02237f5a2..e2d75cc5f 100644 --- a/lib/scsi/lun.c +++ b/lib/scsi/lun.c @@ -106,7 +106,7 @@ spdk_scsi_lun_task_mgmt_execute(struct spdk_scsi_task *task, if (!task->lun) { /* LUN does not exist */ task->response = SPDK_SCSI_TASK_MGMT_RESP_INVALID_LUN; - spdk_scsi_lun_complete_mgmt_task(NULL, task); + task->cpl_fn(task); return -1; }