diff --git a/lib/nvme/nvme_ctrlr.c b/lib/nvme/nvme_ctrlr.c index 85c71409f..8f2bc723e 100644 --- a/lib/nvme/nvme_ctrlr.c +++ b/lib/nvme/nvme_ctrlr.c @@ -2972,15 +2972,7 @@ nvme_ctrlr_update_namespaces(struct spdk_nvme_ctrlr *ctrlr) nsdata = &ns->nsdata; ns_is_active = spdk_nvme_ctrlr_is_active_ns(ctrlr, nsid); - if (nsdata->ncap && ns_is_active) { - NVME_CTRLR_DEBUGLOG(ctrlr, "Namespace %u was updated\n", nsid); - if (nvme_ns_update(ns) != 0) { - NVME_CTRLR_ERRLOG(ctrlr, "Failed to update active NS %u\n", nsid); - continue; - } - } - - if ((nsdata->ncap == 0) && ns_is_active) { + if (ns_is_active) { NVME_CTRLR_DEBUGLOG(ctrlr, "Namespace %u was added\n", nsid); if (nvme_ctrlr_construct_namespace(ctrlr, nsid) != 0) { continue; diff --git a/lib/nvme/nvme_internal.h b/lib/nvme/nvme_internal.h index a49ff20ee..4d32b7146 100644 --- a/lib/nvme/nvme_internal.h +++ b/lib/nvme/nvme_internal.h @@ -1211,7 +1211,6 @@ bool nvme_ns_has_supported_iocs_specific_data(struct spdk_nvme_ns *ns); int nvme_ns_construct(struct spdk_nvme_ns *ns, uint32_t id, struct spdk_nvme_ctrlr *ctrlr); void nvme_ns_destruct(struct spdk_nvme_ns *ns); -int nvme_ns_update(struct spdk_nvme_ns *ns); int nvme_ns_cmd_zone_append_with_md(struct spdk_nvme_ns *ns, struct spdk_nvme_qpair *qpair, void *buffer, void *metadata, uint64_t zslba, uint32_t lba_count, spdk_nvme_cmd_cb cb_fn, void *cb_arg, diff --git a/lib/nvme/nvme_ns.c b/lib/nvme/nvme_ns.c index d52e0d683..718dc3cf0 100644 --- a/lib/nvme/nvme_ns.c +++ b/lib/nvme/nvme_ns.c @@ -580,8 +580,3 @@ void nvme_ns_destruct(struct spdk_nvme_ns *ns) ns->flags = 0; ns->csi = SPDK_NVME_CSI_NVM; } - -int nvme_ns_update(struct spdk_nvme_ns *ns) -{ - return nvme_ctrlr_identify_ns(ns); -} diff --git a/test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c b/test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c index bd444f872..57a80174e 100644 --- a/test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c +++ b/test/unit/lib/nvme/nvme_ctrlr.c/nvme_ctrlr_ut.c @@ -686,12 +686,6 @@ nvme_ns_construct(struct spdk_nvme_ns *ns, uint32_t id, return 0; } -int -nvme_ns_update(struct spdk_nvme_ns *ns) -{ - return 0; -} - void spdk_pci_device_detach(struct spdk_pci_device *device) {