From fb6f88cc88e0dc36fb2622e86f5cbf756e2f126f Mon Sep 17 00:00:00 2001 From: Jim Harris Date: Wed, 8 Jun 2022 22:55:32 +0000 Subject: [PATCH] env_dpdk: remove -rpath-link from ENV_LINKER_ARGS We already list the libraries with their explicit pathnames, so the -rpath-link serves no purpose. Our Makefile was actually specifying this option without an = sign - i.e: -Wl,-rpath-link /path/to/lib On the submitter's system, this resulted in an error: cc: Missing argument for -Wl,-rpath-link I have no idea why no one has ever run into this error, except for this one submitter. But removing the -rpath-link is the right thing to do here, since it is not needed - so do that rather than adding the = sign and continuing to figure out differences in -Wl option processing on these different systems.. Fixes issue #2540. Signed-off-by: Jim Harris Change-Id: I4f6176e55701a5dea5b10bba1ad621250cb5cb51 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12984 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Tomasz Zawadzki Reviewed-by: Dong Yi Reviewed-by: Konrad Sztyber --- lib/env_dpdk/env.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/env_dpdk/env.mk b/lib/env_dpdk/env.mk index 87d14d833..2558743d9 100644 --- a/lib/env_dpdk/env.mk +++ b/lib/env_dpdk/env.mk @@ -172,12 +172,12 @@ endif ifeq ($(CONFIG_SHARED),y) ENV_DPDK_FILE = $(call spdk_lib_list_to_shared_libs,env_dpdk) ENV_LIBS = $(ENV_DPDK_FILE) $(DPDK_SHARED_LIB) -DPDK_LINKER_ARGS = -Wl,-rpath-link $(DPDK_LIB_DIR) $(DPDK_SHARED_LIB_LINKER_ARGS) +DPDK_LINKER_ARGS = $(DPDK_SHARED_LIB_LINKER_ARGS) ENV_LINKER_ARGS = $(ENV_DPDK_FILE) $(DPDK_LINKER_ARGS) else ENV_DPDK_FILE = $(call spdk_lib_list_to_static_libs,env_dpdk) ENV_LIBS = $(ENV_DPDK_FILE) $(DPDK_STATIC_LIB) -DPDK_LINKER_ARGS = -Wl,-rpath-link $(DPDK_LIB_DIR) $(DPDK_STATIC_LIB_LINKER_ARGS) +DPDK_LINKER_ARGS = $(DPDK_STATIC_LIB_LINKER_ARGS) ENV_LINKER_ARGS = $(ENV_DPDK_FILE) $(DPDK_LINKER_ARGS) ENV_LINKER_ARGS += $(DPDK_PRIVATE_LINKER_ARGS) endif