From fb67f90b311617fa4b24be0807a600ca1a7ed3a2 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Wed, 19 May 2021 20:59:08 +0200 Subject: [PATCH] app/trace: move stats update out of print_event It'll make it a bit easier to support printing traces in different formats. Signed-off-by: Konrad Sztyber Change-Id: I33d454868fe7975ce81046823e3a3b9b6f587b0f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/8102 Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- app/trace/trace.cpp | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/app/trace/trace.cpp b/app/trace/trace.cpp index 2444d1344..b83e0be83 100644 --- a/app/trace/trace.cpp +++ b/app/trace/trace.cpp @@ -178,14 +178,6 @@ print_event(struct spdk_trace_entry *e, uint64_t tsc_rate, d = &g_histories->flags.tpoint[e->tpoint_id]; stats = &g_stats[d->object_type]; - - if (d->new_object) { - stats->index[e->object_id] = stats->counter++; - stats->tpoint_id[e->object_id] = e->tpoint_id; - stats->start[e->object_id] = e->tsc; - stats->size[e->object_id] = e->size; - } - us = get_us_from_tsc(e->tsc - tsc_offset, tsc_rate); printf("%2d: %10.3f ", lcore, us); @@ -228,6 +220,19 @@ static void process_event(struct spdk_trace_entry *e, uint64_t tsc_rate, uint64_t tsc_offset, uint16_t lcore) { + struct spdk_trace_tpoint *d; + struct object_stats *stats; + + d = &g_histories->flags.tpoint[e->tpoint_id]; + stats = &g_stats[d->object_type]; + + if (d->new_object) { + stats->index[e->object_id] = stats->counter++; + stats->tpoint_id[e->object_id] = e->tpoint_id; + stats->start[e->object_id] = e->tsc; + stats->size[e->object_id] = e->size; + } + if (g_verbose) { print_event(e, tsc_rate, tsc_offset, lcore); }