ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

env/dpdk: add spdk_pci_fini()

Browse Source 
It's mostly needed for the next patch, but even
now it provides some value by printing errors if
there any leaked (still attached) PCI devices
at shutdown.

Change-Id: I8459a6049b3c6612d9f1d99444bf3acfd474a839
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/449082
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Darek Stojaczyk 2019-03-25 21:17:23 +01:00 committed by Jim Harris
parent 04814b72a8
commit fb51565a59
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/env_dpdk/env_internal.h
View File

@ -78,6 +78,7 @@ int spdk_pci_device_init(struct rte_pci_driver *driver, struct rte_pci_device *d
int spdk_pci_device_fini(struct rte_pci_device *device);
void spdk_pci_init(void);
void spdk_pci_fini(void);
int spdk_mem_map_init(void);
int spdk_vtophys_init(void);

2
lib/env_dpdk/init.c
View File

@ -385,6 +385,8 @@ spdk_env_dpdk_post_init(void)
void
spdk_env_dpdk_post_fini(void)
{
spdk_pci_fini();
spdk_free_args(g_eal_cmdline, g_eal_cmdline_argcount);
}

14
lib/env_dpdk/pci.c
View File

@ -147,6 +147,20 @@ spdk_pci_init(void)
#endif
}
void
spdk_pci_fini(void)
{
struct spdk_pci_device *dev;
char bdf[32];
TAILQ_FOREACH(dev, &g_pci_devices, internal.tailq) {
if (dev->internal.attached) {
spdk_pci_addr_fmt(bdf, sizeof(bdf), &dev->addr);
fprintf(stderr, "Device %s is still attached at shutdown!\n", bdf);
}
}
}
int
spdk_pci_device_init(struct rte_pci_driver *_drv,
struct rte_pci_device *_dev)