From faacc878114f8697be2a7169e650a4630ddea170 Mon Sep 17 00:00:00 2001 From: Changpeng Liu Date: Thu, 24 Jan 2019 22:12:17 -0500 Subject: [PATCH] nvmf: set default KAS value to 10 seconds Both initiator and target are using the minium 10 seconds timeout value, so set it in kas field when initializing the controller. Change-Id: Idda68bdfe27613ebaf706a0de497145d3f9ed766 Signed-off-by: Changpeng Liu Reviewed-on: https://review.gerrithub.io/c/441995 Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- lib/nvmf/ctrlr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index e1c27e2f7..d8669fbb4 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -49,8 +49,8 @@ #define MIN_KEEP_ALIVE_TIMEOUT_IN_MS 10000 #define NVMF_DISC_KATO_IN_MS 120000 -#define KAS_DEFAULT_VALUE 10 #define KAS_TIME_UNIT_IN_MS 100 +#define KAS_DEFAULT_VALUE (MIN_KEEP_ALIVE_TIMEOUT_IN_MS / KAS_TIME_UNIT_IN_MS) #define MODEL_NUMBER "SPDK bdev Controller" @@ -281,7 +281,6 @@ spdk_nvmf_ctrlr_create(struct spdk_nvmf_subsystem *subsystem, } /* - * Because Identify Controller data KAS default is 10 * KAS: this field indicates the granularity of the Keep Alive Timer in 100ms units * keep-alive timeout in milliseconds */