ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

examples/ioat/verify: fix misaligned pointer

Browse Source 
Dereferencing a non-8-byte-aligned uint64_t pointer is undefined
behavior (caught by UBSan).  Use memcmp() instead for an equivalent test
that works at any byte alignment.

Change-Id: I641b11abe9c5fc99d4c57b0b4ba15eb6a8d6d000
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
This commit is contained in:
Daniel Verkamp 2016-12-06 13:33:35 -07:00
parent 87eb023afe
commit f9be7a36f6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
examples/ioat/verify/verify.c
View File

@ -163,20 +163,20 @@ static void prepare_ioat_task(struct thread_entry *thread_entry, struct ioat_tas
static void static void
ioat_done(void *cb_arg) ioat_done(void *cb_arg)
{ {
uint64_t *value; char *value;
int i, failed = 0; int i, failed = 0;
struct ioat_task *ioat_task = (struct ioat_task *)cb_arg; struct ioat_task *ioat_task = (struct ioat_task *)cb_arg;
struct thread_entry *thread_entry = ioat_task->thread_entry; struct thread_entry *thread_entry = ioat_task->thread_entry;
if (ioat_task->type == IOAT_FILL_TYPE) { if (ioat_task->type == IOAT_FILL_TYPE) {
value = (uint64_t *)ioat_task->dst; value = ioat_task->dst;
for (i = 0; i < ioat_task->len / 8; i++) { for (i = 0; i < ioat_task->len / 8; i++) {
if (*value != ioat_task->fill_pattern) { if (memcmp(value, &ioat_task->fill_pattern, 8) != 0) {
thread_entry->fill_failed++; thread_entry->fill_failed++;
failed = 1; failed = 1;
break; break;
} }
value++; value += 8;
} }
if (!failed) if (!failed)
thread_entry->fill_completed++; thread_entry->fill_completed++;