From f955c75ef4276f9b3562c20eb7d36b178caca9b7 Mon Sep 17 00:00:00 2001 From: Tomasz Zawadzki Date: Thu, 16 Apr 2020 09:53:37 -0400 Subject: [PATCH] lib/nvme: free io buffer for nvme_io_msg This buffer was not released after failure to enqueue. Signed-off-by: Tomasz Zawadzki Change-Id: If84317c67626a3193851c90be056b8550a5fccee Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1916 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Ben Walker --- lib/nvme/nvme_io_msg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/nvme/nvme_io_msg.c b/lib/nvme/nvme_io_msg.c index 4223fe1a6..dfaa49006 100644 --- a/lib/nvme/nvme_io_msg.c +++ b/lib/nvme/nvme_io_msg.c @@ -64,6 +64,7 @@ nvme_io_msg_send(struct spdk_nvme_ctrlr *ctrlr, uint32_t nsid, spdk_nvme_io_msg_ rc = spdk_ring_enqueue(ctrlr->external_io_msgs, (void **)&io, 1, NULL); if (rc != 1) { assert(false); + free(io); pthread_mutex_unlock(&ctrlr->external_io_msgs_lock); return -ENOMEM; }