ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/iscsi: Release request after connection is done

Browse Source 
This request was getting leaked previously.

Change-Id: I6e7dc24c92d7bae7a8df54025d61eb391a569df9
Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1591
Community-CI: Broadcom CI
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Ben Walker 2020-03-30 15:37:20 -07:00 committed by Tomasz Zawadzki
parent 50529593c4
commit f76cf58294
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
module/bdev/iscsi/bdev_iscsi.c
View File

@ -144,7 +144,6 @@ _iscsi_free_lun(void *arg)
static void static void
_bdev_iscsi_conn_req_free(struct bdev_iscsi_conn_req *req) _bdev_iscsi_conn_req_free(struct bdev_iscsi_conn_req *req)
{ {
free(req->initiator_iqn); free(req->initiator_iqn);
free(req->bdev_name); free(req->bdev_name);
free(req->url); free(req->url);
@ -771,7 +770,12 @@ iscsi_bdev_conn_poll(void *arg)
} }
} }
if (req->status != SCSI_STATUS_GOOD) { if (req->status == 0) {
/*
* The request completed successfully.
*/
free(req);
} else if (req->status > 0) {
/* /*
* An error has occurred during connecting. This req has already * An error has occurred during connecting. This req has already
* been removed from the g_iscsi_conn_req list, but we needed to * been removed from the g_iscsi_conn_req list, but we needed to
@ -838,6 +842,7 @@ create_iscsi_disk(const char *bdev_name, const char *url, const char *initiator_
} }
iscsi_destroy_url(iscsi_url); iscsi_destroy_url(iscsi_url);
req->status = -1;
TAILQ_INSERT_TAIL(&g_iscsi_conn_req, req, link); TAILQ_INSERT_TAIL(&g_iscsi_conn_req, req, link);
if (!g_conn_poller) { if (!g_conn_poller) {
g_conn_poller = spdk_poller_register(iscsi_bdev_conn_poll, NULL, BDEV_ISCSI_CONNECTION_POLL_US); g_conn_poller = spdk_poller_register(iscsi_bdev_conn_poll, NULL, BDEV_ISCSI_CONNECTION_POLL_US);