From f75d67790813d1dbea9b62c812d6e9c529755ec6 Mon Sep 17 00:00:00 2001 From: Karol Latecki Date: Mon, 9 Nov 2020 12:12:26 +0100 Subject: [PATCH] test/make: select ABI reference build for test At given time we support two SPDK versions: - last release - LTS release For ABI tests we need to select proper reference build to check against. Signed-off-by: Karol Latecki Change-Id: I674b6092199c4535288f5062ff0523a13890cbce Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5056 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Shuhei Matsumoto Reviewed-by: Michal Berger --- test/make/check_so_deps.sh | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/test/make/check_so_deps.sh b/test/make/check_so_deps.sh index 154747e5c..f6747bc00 100755 --- a/test/make/check_so_deps.sh +++ b/test/make/check_so_deps.sh @@ -1,6 +1,10 @@ #!/usr/bin/env bash shopt -s extglob +function get_git_tag() { + git -C "${1:-$rootdir}" describe --tags --abbrev=0 +} + if [ "$(uname -s)" = "FreeBSD" ]; then echo "Not testing for shared object dependencies on FreeBSD." exit 0 @@ -18,13 +22,22 @@ source "$rootdir/test/common/autotest_common.sh" libdir="$rootdir/build/lib" libdeps_file="$rootdir/mk/spdk.lib_deps.mk" -source_abi_dir="$HOME/spdk_abi_latest/build/lib" suppression_file="$HOME/abigail_suppressions.ini" +spdk_tag=$(get_git_tag) +spdk_lts_tag=$(get_git_tag "$HOME/spdk_abi_lts") +repo="spdk_abi_latest" +if [[ "$spdk_tag" == "$spdk_lts_tag" ]]; then + repo="spdk_abi_lts" +fi +source_abi_dir="$HOME/$repo/build/lib" + function confirm_abi_deps() { local processed_so=0 local abidiff_output + echo "* Running ${FUNCNAME[0]} against $repo" >&2 + if ! hash abidiff; then echo "Unable to check ABI compatibility. Please install abidiff." return 1