ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi: remove unnecessary mutex

Browse Source 
target->mutex doesn't guard any data structure.

Change-Id: I07d75b43d0b016e3c6b56baab4b1707887ab019d
Signed-off-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-on: https://review.gerrithub.io/414362
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Shuhei Matsumoto 2018-06-08 16:58:53 +09:00 committed by Jim Harris
parent feb7f2b3fc
commit f71aa70005
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/iscsi/iscsi.c
View File

@ -4582,10 +4582,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn,
/* configuration values */ /* configuration values */
pthread_mutex_lock(&g_spdk_iscsi.mutex); pthread_mutex_lock(&g_spdk_iscsi.mutex);
if (target != NULL) {
pthread_mutex_lock(&target->mutex);
}
sess->MaxConnections = g_spdk_iscsi.MaxConnectionsPerSession; sess->MaxConnections = g_spdk_iscsi.MaxConnectionsPerSession;
sess->MaxOutstandingR2T = DEFAULT_MAXOUTSTANDINGR2T; sess->MaxOutstandingR2T = DEFAULT_MAXOUTSTANDINGR2T;
@ -4599,10 +4595,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn,
sess->DataSequenceInOrder = DEFAULT_DATASEQUENCEINORDER; sess->DataSequenceInOrder = DEFAULT_DATASEQUENCEINORDER;
sess->ErrorRecoveryLevel = g_spdk_iscsi.ErrorRecoveryLevel; sess->ErrorRecoveryLevel = g_spdk_iscsi.ErrorRecoveryLevel;
if (target != NULL) {
pthread_mutex_unlock(&target->mutex);
}
pthread_mutex_unlock(&g_spdk_iscsi.mutex); pthread_mutex_unlock(&g_spdk_iscsi.mutex);
sess->tag = conn->portal->group->tag; sess->tag = conn->portal->group->tag;