From f71aa7000514f5232e761310e46f0084f7d948be Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Fri, 8 Jun 2018 16:58:53 +0900 Subject: [PATCH] iscsi: remove unnecessary mutex target->mutex doesn't guard any data structure. Change-Id: I07d75b43d0b016e3c6b56baab4b1707887ab019d Signed-off-by: Shuhei Matsumoto Reviewed-on: https://review.gerrithub.io/414362 Tested-by: SPDK Automated Test System Reviewed-by: Dariusz Stojaczyk Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- lib/iscsi/iscsi.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c index a4b1e221d..bf7637e78 100644 --- a/lib/iscsi/iscsi.c +++ b/lib/iscsi/iscsi.c @@ -4582,10 +4582,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn, /* configuration values */ pthread_mutex_lock(&g_spdk_iscsi.mutex); - if (target != NULL) { - pthread_mutex_lock(&target->mutex); - } - sess->MaxConnections = g_spdk_iscsi.MaxConnectionsPerSession; sess->MaxOutstandingR2T = DEFAULT_MAXOUTSTANDINGR2T; @@ -4599,10 +4595,6 @@ spdk_create_iscsi_sess(struct spdk_iscsi_conn *conn, sess->DataSequenceInOrder = DEFAULT_DATASEQUENCEINORDER; sess->ErrorRecoveryLevel = g_spdk_iscsi.ErrorRecoveryLevel; - if (target != NULL) { - pthread_mutex_unlock(&target->mutex); - } - pthread_mutex_unlock(&g_spdk_iscsi.mutex); sess->tag = conn->portal->group->tag;