From f603c2727645ab82673d9a88c2ead81482f53761 Mon Sep 17 00:00:00 2001 From: paul luse Date: Thu, 9 Apr 2020 12:19:30 -0400 Subject: [PATCH] lib/idxd: add unit test framework and first unit test More tests will follow in later patches. Signed-off-by: paul luse Change-Id: I6c45b94cc17219acfae863c774fc7dbc33625c85 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1782 Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- test/unit/lib/Makefile | 1 + test/unit/lib/idxd/Makefile | 44 ++++++++++ test/unit/lib/idxd/idxd.c/.gitignore | 1 + test/unit/lib/idxd/idxd.c/Makefile | 38 ++++++++ test/unit/lib/idxd/idxd.c/idxd_ut.c | 124 +++++++++++++++++++++++++++ test/unit/unittest.sh | 3 + 6 files changed, 211 insertions(+) create mode 100644 test/unit/lib/idxd/Makefile create mode 100644 test/unit/lib/idxd/idxd.c/.gitignore create mode 100644 test/unit/lib/idxd/idxd.c/Makefile create mode 100644 test/unit/lib/idxd/idxd.c/idxd_ut.c diff --git a/test/unit/lib/Makefile b/test/unit/lib/Makefile index 1d748977b..aa2d707ab 100644 --- a/test/unit/lib/Makefile +++ b/test/unit/lib/Makefile @@ -36,6 +36,7 @@ include $(SPDK_ROOT_DIR)/mk/spdk.common.mk DIRS-y = bdev blob blobfs event ioat iscsi json jsonrpc log lvol DIRS-y += notify nvme nvmf scsi sock thread util +DIRS-$(CONFIG_IDXD) += idxd DIRS-$(CONFIG_REDUCE) += reduce ifeq ($(OS),Linux) DIRS-$(CONFIG_VHOST) += vhost diff --git a/test/unit/lib/idxd/Makefile b/test/unit/lib/idxd/Makefile new file mode 100644 index 000000000..e37cb22d9 --- /dev/null +++ b/test/unit/lib/idxd/Makefile @@ -0,0 +1,44 @@ +# +# BSD LICENSE +# +# Copyright (c) Intel Corporation. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in +# the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Intel Corporation nor the names of its +# contributors may be used to endorse or promote products derived +# from this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# + +SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../..) +include $(SPDK_ROOT_DIR)/mk/spdk.common.mk + +DIRS-y = idxd.c + +.PHONY: all clean $(DIRS-y) + +all: $(DIRS-y) +clean: $(DIRS-y) + +include $(SPDK_ROOT_DIR)/mk/spdk.subdirs.mk diff --git a/test/unit/lib/idxd/idxd.c/.gitignore b/test/unit/lib/idxd/idxd.c/.gitignore new file mode 100644 index 000000000..b9fee58fe --- /dev/null +++ b/test/unit/lib/idxd/idxd.c/.gitignore @@ -0,0 +1 @@ +idxd_ut diff --git a/test/unit/lib/idxd/idxd.c/Makefile b/test/unit/lib/idxd/idxd.c/Makefile new file mode 100644 index 000000000..73fdbe3e4 --- /dev/null +++ b/test/unit/lib/idxd/idxd.c/Makefile @@ -0,0 +1,38 @@ +# +# BSD LICENSE +# +# Copyright (c) Intel Corporation. +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in +# the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Intel Corporation nor the names of its +# contributors may be used to endorse or promote products derived +# from this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# + +SPDK_ROOT_DIR := $(abspath $(CURDIR)/../../../../..) + +TEST_FILE = idxd_ut.c + +include $(SPDK_ROOT_DIR)/mk/spdk.unittest.mk diff --git a/test/unit/lib/idxd/idxd.c/idxd_ut.c b/test/unit/lib/idxd/idxd.c/idxd_ut.c new file mode 100644 index 000000000..87274a3f9 --- /dev/null +++ b/test/unit/lib/idxd/idxd.c/idxd_ut.c @@ -0,0 +1,124 @@ +/*- + * BSD LICENSE + * + * Copyright (c) Intel Corporation. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Intel Corporation nor the names of its + * contributors may be used to endorse or promote products derived + * from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "spdk_cunit.h" +#include "spdk_internal/mock.h" +#include "common/lib/test_env.c" +#include "idxd/idxd.c" + +int +spdk_pci_enumerate(struct spdk_pci_driver *driver, spdk_pci_enum_cb enum_cb, void *enum_ctx) +{ + return -1; +} + +int +spdk_pci_device_map_bar(struct spdk_pci_device *dev, uint32_t bar, + void **mapped_addr, uint64_t *phys_addr, uint64_t *size) +{ + *mapped_addr = NULL; + *phys_addr = 0; + *size = 0; + return 0; +} + +int +spdk_pci_device_unmap_bar(struct spdk_pci_device *dev, uint32_t bar, void *addr) +{ + return 0; +} + +int +spdk_pci_device_cfg_read32(struct spdk_pci_device *dev, uint32_t *value, + uint32_t offset) +{ + *value = 0xFFFFFFFFu; + return 0; +} + +int +spdk_pci_device_cfg_write32(struct spdk_pci_device *dev, uint32_t value, + uint32_t offset) +{ + return 0; +} + +#define movdir64b mock_movdir64b +static inline void +mock_movdir64b(void *dst, const void *src) +{ + return; +} + +static int +test_spdk_idxd_reconfigure_chan(void) +{ + struct spdk_idxd_io_channel chan = {}; + int rc; + uint32_t test_ring_size = 8; + uint32_t num_channels = 2; + + chan.ring_ctrl.ring_slots = spdk_bit_array_create(test_ring_size); + chan.ring_ctrl.ring_size = test_ring_size; + chan.ring_ctrl.completions = spdk_zmalloc(test_ring_size * sizeof(struct idxd_hw_desc), 0, NULL, + SPDK_ENV_LCORE_ID_ANY, SPDK_MALLOC_DMA); + SPDK_CU_ASSERT_FATAL(chan.ring_ctrl.completions != NULL); + + rc = spdk_idxd_reconfigure_chan(&chan, num_channels); + CU_ASSERT(rc == 0); + CU_ASSERT(chan.ring_ctrl.max_ring_slots == test_ring_size / num_channels); + + spdk_bit_array_free(&chan.ring_ctrl.ring_slots); + spdk_free(chan.ring_ctrl.completions); + return 0; +} + + +int main(int argc, char **argv) +{ + CU_pSuite suite = NULL; + unsigned int num_failures; + + CU_set_error_action(CUEA_ABORT); + CU_initialize_registry(); + + suite = CU_add_suite("idxd", NULL, NULL); + + CU_ADD_TEST(suite, test_spdk_idxd_reconfigure_chan); + + CU_basic_set_mode(CU_BRM_VERBOSE); + CU_basic_run_tests(); + num_failures = CU_get_number_of_failures(); + CU_cleanup_registry(); + return num_failures; +} diff --git a/test/unit/unittest.sh b/test/unit/unittest.sh index ac55dfa97..a60603d6e 100755 --- a/test/unit/unittest.sh +++ b/test/unit/unittest.sh @@ -181,6 +181,9 @@ if [ $(uname -s) = Linux ]; then fi run_test "unittest_ioat" $valgrind $testdir/lib/ioat/ioat.c/ioat_ut +if [ $(uname -m) != "aarch64" ]; then + run_test "unittest_idxd" $valgrind $testdir/lib/idxd/idxd.c/idxd_ut +fi run_test "unittest_iscsi" unittest_iscsi run_test "unittest_json" unittest_json run_test "unittest_notify" $valgrind $testdir/lib/notify/notify.c/notify_ut