ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme/opal: remove the flush operation before each OPAL method

Browse Source 
It's not an error to send a security receive command before each
real OPAL related commands, but we don't need to do it.

Change-Id: I7628988df6ac097264db2137440f63db9e6e3660
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1127
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
This commit is contained in:
Changpeng Liu 2020-03-04 22:04:53 +08:00 committed by Tomasz Zawadzki
parent 0cd8b2927e
commit f55717c34e
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/nvme/nvme_opal.c
View File

@ -41,23 +41,6 @@ typedef int (*spdk_opal_cb)(struct spdk_opal_dev *dev, void *ctx);
static int opal_parse_and_check_status(struct spdk_opal_dev *dev, void *data);
static int
opal_flush_response_buffer(struct spdk_opal_dev *dev)
{
void *response = dev->resp;
int ret = 0;
ret = spdk_nvme_ctrlr_security_receive(dev->ctrlr, SPDK_SCSI_SECP_TCG, dev->comid,
0, response, IO_BUFFER_LENGTH);
if (ret) {
SPDK_ERRLOG("Security Receive Error on dev = %p\n", dev);
return ret;
}
memset(response, 0, IO_BUFFER_LENGTH);
return 0;
}
static int
opal_send_cmd(struct spdk_opal_dev *dev)
{
@ -114,11 +97,6 @@ opal_send_recv(struct spdk_opal_dev *dev, spdk_opal_cb cb, void *data)
{
int ret;
ret = opal_flush_response_buffer(dev);
if (ret) {
return ret;
}
ret = opal_send_cmd(dev);
if (ret) {
return ret;