ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

trace module: remove support for deprecated RPC names

Browse Source 
These were deprecated in 2019, it's time to remove
support for them now.

Change-Id: Ie50c7421f991ad0474edba0e0f339180f7afee00
Signed-off-by: wanghailiangx <hailiangx.e.wang@intel.com>
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/12778
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com>
Reviewed-by: Aleksey Marchuk <alexeymar@nvidia.com>
This commit is contained in:
wanghailiangx 2022-05-23 05:35:37 -04:00 committed by Tomasz Zawadzki
parent 7506a7aa53
commit f552937ef4
3 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/trace/trace_rpc.c
View File

@ -162,7 +162,6 @@ invalid:
} }
SPDK_RPC_REGISTER("trace_enable_tpoint_group", rpc_trace_enable_tpoint_group, SPDK_RPC_REGISTER("trace_enable_tpoint_group", rpc_trace_enable_tpoint_group,
SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME) SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(trace_enable_tpoint_group, enable_tpoint_group)
static void static void
rpc_trace_disable_tpoint_group(struct spdk_jsonrpc_request *request, rpc_trace_disable_tpoint_group(struct spdk_jsonrpc_request *request,
@ -196,7 +195,6 @@ invalid:
} }
SPDK_RPC_REGISTER("trace_disable_tpoint_group", rpc_trace_disable_tpoint_group, SPDK_RPC_REGISTER("trace_disable_tpoint_group", rpc_trace_disable_tpoint_group,
SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME) SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(trace_disable_tpoint_group, disable_tpoint_group)
static void static void
rpc_trace_get_tpoint_group_mask(struct spdk_jsonrpc_request *request, rpc_trace_get_tpoint_group_mask(struct spdk_jsonrpc_request *request,
@ -241,4 +239,3 @@ rpc_trace_get_tpoint_group_mask(struct spdk_jsonrpc_request *request,
} }
SPDK_RPC_REGISTER("trace_get_tpoint_group_mask", rpc_trace_get_tpoint_group_mask, SPDK_RPC_REGISTER("trace_get_tpoint_group_mask", rpc_trace_get_tpoint_group_mask,
SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME) SPDK_RPC_STARTUP | SPDK_RPC_RUNTIME)
SPDK_RPC_REGISTER_ALIAS_DEPRECATED(trace_get_tpoint_group_mask, get_tpoint_group_mask)

3
python/spdk/rpc/trace.py
View File

@ -1,7 +1,6 @@
from .helpers import deprecated_alias from .helpers import deprecated_alias
@deprecated_alias('enable_tpoint_group')
def trace_enable_tpoint_group(client, name): def trace_enable_tpoint_group(client, name):
"""Enable trace on a specific tpoint group. """Enable trace on a specific tpoint group.
@ -12,7 +11,6 @@ def trace_enable_tpoint_group(client, name):
return client.call('trace_enable_tpoint_group', params) return client.call('trace_enable_tpoint_group', params)
@deprecated_alias('disable_tpoint_group')
def trace_disable_tpoint_group(client, name): def trace_disable_tpoint_group(client, name):
"""Disable trace on a specific tpoint group. """Disable trace on a specific tpoint group.
@ -47,7 +45,6 @@ def trace_clear_tpoint_mask(client, name, tpoint_mask):
return client.call('trace_clear_tpoint_mask', params) return client.call('trace_clear_tpoint_mask', params)
@deprecated_alias('get_tpoint_group_mask')
def trace_get_tpoint_group_mask(client): def trace_get_tpoint_group_mask(client):
"""Get trace point group mask """Get trace point group mask

7
scripts/rpc.py
View File

@ -1665,7 +1665,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
def trace_enable_tpoint_group(args): def trace_enable_tpoint_group(args):
rpc.trace.trace_enable_tpoint_group(args.client, name=args.name) rpc.trace.trace_enable_tpoint_group(args.client, name=args.name)
p = subparsers.add_parser('trace_enable_tpoint_group', aliases=['enable_tpoint_group'], p = subparsers.add_parser('trace_enable_tpoint_group',
help='enable trace on a specific tpoint group') help='enable trace on a specific tpoint group')
p.add_argument( p.add_argument(
'name', help="""trace group name we want to enable in tpoint_group_mask. 'name', help="""trace group name we want to enable in tpoint_group_mask.
@ -1675,7 +1675,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
def trace_disable_tpoint_group(args): def trace_disable_tpoint_group(args):
rpc.trace.trace_disable_tpoint_group(args.client, name=args.name) rpc.trace.trace_disable_tpoint_group(args.client, name=args.name)
p = subparsers.add_parser('trace_disable_tpoint_group', aliases=['disable_tpoint_group'], p = subparsers.add_parser('trace_disable_tpoint_group',
help='disable trace on a specific tpoint group') help='disable trace on a specific tpoint group')
p.add_argument( p.add_argument(
'name', help="""trace group name we want to disable in tpoint_group_mask. 'name', help="""trace group name we want to disable in tpoint_group_mask.
@ -1713,8 +1713,7 @@ Format: 'user:u1 secret:s1 muser:mu1 msecret:ms1,user:u2 secret:s2 muser:mu2 mse
def trace_get_tpoint_group_mask(args): def trace_get_tpoint_group_mask(args):
print_dict(rpc.trace.trace_get_tpoint_group_mask(args.client)) print_dict(rpc.trace.trace_get_tpoint_group_mask(args.client))
p = subparsers.add_parser('trace_get_tpoint_group_mask', aliases=['get_tpoint_group_mask'], p = subparsers.add_parser('trace_get_tpoint_group_mask', help='get trace point group mask')
help='get trace point group mask')
p.set_defaults(func=trace_get_tpoint_group_mask) p.set_defaults(func=trace_get_tpoint_group_mask)
# log # log