From f4e536cb579b5d34ccb67bd9846f751b08056bb4 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Mon, 23 Dec 2019 20:51:35 -0500 Subject: [PATCH] bdevperf: Use rpc_perform_tests_cb to remove duplicated code Due to the last patch, we can use rpc_perform_tests_cb() in rpc_perform_tests() simply and remove the duplicated code. Signed-off-by: Shuhei Matsumoto Change-Id: Id56da12fb5c52b6d178912f2f6cc7ead8a9cc36e Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/478761 Tested-by: SPDK CI Jenkins Community-CI: SPDK CI Jenkins Reviewed-by: Ben Walker Reviewed-by: Jim Harris --- test/bdev/bdevperf/bdevperf.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/bdev/bdevperf/bdevperf.c b/test/bdev/bdevperf/bdevperf.c index e3d848e4b..6d6bae41d 100644 --- a/test/bdev/bdevperf/bdevperf.c +++ b/test/bdev/bdevperf/bdevperf.c @@ -1458,11 +1458,7 @@ rpc_perform_tests(struct spdk_jsonrpc_request *request, const struct spdk_json_v rc = bdevperf_test(); if (rc) { - g_request = NULL; - bdevperf_free_targets(); - spdk_jsonrpc_send_error_response_fmt(request, SPDK_JSONRPC_ERROR_INTERNAL_ERROR, - "Could not perform tests due to error: %s", spdk_strerror(-rc)); - return; + rpc_perform_tests_cb(rc); } } SPDK_RPC_REGISTER("perform_tests", rpc_perform_tests, SPDK_RPC_RUNTIME)