From f4369b9eed65485d14d6953c588d7b28e8364d37 Mon Sep 17 00:00:00 2001 From: Maciej Szwed Date: Tue, 31 Jul 2018 08:36:51 +0200 Subject: [PATCH] nvme: fix memory leak on NVMe bdev creation failure Signed-off-by: Maciej Szwed Change-Id: If90434452dba51fbb72c8c486e3c1e4691549c34 Reviewed-on: https://review.gerrithub.io/420845 Reviewed-by: Xiaodong Liu Reviewed-by: Jim Harris Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins --- lib/bdev/nvme/bdev_nvme.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bdev/nvme/bdev_nvme.c b/lib/bdev/nvme/bdev_nvme.c index ee2961879..f64d25d72 100644 --- a/lib/bdev/nvme/bdev_nvme.c +++ b/lib/bdev/nvme/bdev_nvme.c @@ -955,6 +955,8 @@ create_ctrlr(struct spdk_nvme_ctrlr *ctrlr, if (nvme_ctrlr_create_bdevs(nvme_ctrlr) != 0) { spdk_io_device_unregister(ctrlr, NULL); + free(nvme_ctrlr->bdevs); + free(nvme_ctrlr->name); free(nvme_ctrlr); return -1; }