ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev/gpt: use per-base split tailq

Browse Source 
Currently spdk_bdev_part_base_get_tailq(gpt_base) will
return the global gpt tailq containing all the gpt part
bdevs, which is not what callers of this function expect.

Although the spdk_bdev_part_base_get_tailq() is currently
unused for gpt parts, it's still worth fixing it to make
the behavior consistent with other part bdev modules.

Fix this by having per-gpt-base tailqs which contain only
associated gpt partitions.

Change-Id: Ib3c4286fcc6912f2a252beb5b3dcafc0e5316434
Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-on: https://review.gerrithub.io/434836
Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Paul Luse <paul.e.luse@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Darek Stojaczyk 2018-11-26 14:13:21 +01:00 committed by Jim Harris
parent 230857be48
commit f40ab9893d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/bdev/gpt/vbdev_gpt.c
View File

@ -66,6 +66,7 @@ SPDK_BDEV_MODULE_REGISTER(&gpt_if)
struct gpt_base {
struct spdk_gpt gpt;
struct spdk_bdev_part_base *part_base;
SPDK_BDEV_PART_TAILQ parts;
/* This channel is only used for reading the partition table. */
struct spdk_io_channel *ch;
@ -89,8 +90,6 @@ struct gpt_io {
struct spdk_bdev_io_wait_entry bdev_io_wait;
};
static SPDK_BDEV_PART_TAILQ g_gpt_disks = TAILQ_HEAD_INITIALIZER(g_gpt_disks);
static bool g_gpt_disabled;
static void
@ -106,8 +105,9 @@ static void
spdk_gpt_base_bdev_hotremove_cb(void *_part_base)
{
struct spdk_bdev_part_base *part_base = _part_base;
struct gpt_base *gpt_base = spdk_bdev_part_base_get_ctx(part_base);
spdk_bdev_part_base_hotremove(part_base, &g_gpt_disks);
spdk_bdev_part_base_hotremove(part_base, &gpt_base->parts);
}
static int vbdev_gpt_destruct(void *ctx);
@ -132,10 +132,11 @@ spdk_gpt_base_bdev_init(struct spdk_bdev *bdev)
return NULL;
}
TAILQ_INIT(&gpt_base->parts);
gpt_base->part_base = spdk_bdev_part_base_construct(bdev,
spdk_gpt_base_bdev_hotremove_cb,
&gpt_if, &vbdev_gpt_fn_table,
&g_gpt_disks, spdk_gpt_base_free, gpt_base,
&gpt_base->parts, spdk_gpt_base_free, gpt_base,
sizeof(struct gpt_channel), NULL, NULL);
if (!gpt_base->part_base) {
free(gpt_base);