ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bdev: remove get_ctx_size functions that return 0

Browse Source 
The bdev module get_ctx_size callback is only necessary if it returns a
non-zero size.

Change-Id: I00ca366b8a1949bdb091c5e8aefb19cb606481d0
Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-on: https://review.gerrithub.io/389900
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Daniel Verkamp 2017-11-30 13:45:30 -07:00
parent 474632ba7b
commit f3e0bfd7ef
5 changed files with 5 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/bdev/gpt/vbdev_gpt.c
View File

@ -381,12 +381,6 @@ vbdev_gpt_examine(struct spdk_bdev *bdev)
} }
} }
static int
vbdev_gpt_get_ctx_size(void)
{
return 0;
}
SPDK_BDEV_MODULE_REGISTER(gpt, vbdev_gpt_init, vbdev_gpt_fini, NULL, SPDK_BDEV_MODULE_REGISTER(gpt, vbdev_gpt_init, vbdev_gpt_fini, NULL,
vbdev_gpt_get_ctx_size, vbdev_gpt_examine) NULL, vbdev_gpt_examine)
SPDK_LOG_REGISTER_TRACE_FLAG("vbdev_gpt", SPDK_TRACE_VBDEV_GPT) SPDK_LOG_REGISTER_TRACE_FLAG("vbdev_gpt", SPDK_TRACE_VBDEV_GPT)

8
lib/bdev/null/bdev_null.c
View File

@ -53,12 +53,6 @@ struct null_bdev {
static TAILQ_HEAD(, null_bdev) g_null_bdev_head; static TAILQ_HEAD(, null_bdev) g_null_bdev_head;
static void *g_null_read_buf; static void *g_null_read_buf;
static int
bdev_null_get_ctx_size(void)
{
return 0;
}
static int static int
bdev_null_destruct(void *ctx) bdev_null_destruct(void *ctx)
{ {
@ -295,6 +289,6 @@ bdev_null_get_spdk_running_config(FILE *fp)
} }
SPDK_BDEV_MODULE_REGISTER(null, bdev_null_initialize, bdev_null_finish, SPDK_BDEV_MODULE_REGISTER(null, bdev_null_initialize, bdev_null_finish,
bdev_null_get_spdk_running_config, bdev_null_get_ctx_size, NULL) bdev_null_get_spdk_running_config, NULL, NULL)
SPDK_LOG_REGISTER_TRACE_FLAG("bdev_null", SPDK_TRACE_BDEV_NULL) SPDK_LOG_REGISTER_TRACE_FLAG("bdev_null", SPDK_TRACE_BDEV_NULL)

8
lib/bdev/pmem/bdev_pmem.c
View File

@ -56,14 +56,8 @@ static int pmem_disk_count = 0;
static int bdev_pmem_initialize(void); static int bdev_pmem_initialize(void);
static void bdev_pmem_finish(void); static void bdev_pmem_finish(void);
static int
bdev_pmem_get_ctx_size(void)
{
return 0;
}
SPDK_BDEV_MODULE_REGISTER(pmem, bdev_pmem_initialize, bdev_pmem_finish, SPDK_BDEV_MODULE_REGISTER(pmem, bdev_pmem_initialize, bdev_pmem_finish,
NULL, bdev_pmem_get_ctx_size, NULL) NULL, NULL, NULL)
SPDK_BDEV_MODULE_ASYNC_FINI(pmem); SPDK_BDEV_MODULE_ASYNC_FINI(pmem);

8
lib/bdev/rbd/bdev_rbd.c
View File

@ -201,14 +201,8 @@ bdev_rbd_start_aio(rbd_image_t image, struct spdk_bdev_io *bdev_io,
static int bdev_rbd_library_init(void); static int bdev_rbd_library_init(void);
static void bdev_rbd_library_fini(void); static void bdev_rbd_library_fini(void);
static int
bdev_rbd_get_ctx_size(void)
{
return 0;
}
SPDK_BDEV_MODULE_REGISTER(rbd, bdev_rbd_library_init, bdev_rbd_library_fini, NULL, SPDK_BDEV_MODULE_REGISTER(rbd, bdev_rbd_library_init, bdev_rbd_library_fini, NULL,
bdev_rbd_get_ctx_size, NULL) NULL, NULL)
static int64_t static int64_t
bdev_rbd_rw(struct bdev_rbd *disk, struct spdk_io_channel *ch, bdev_rbd_rw(struct bdev_rbd *disk, struct spdk_io_channel *ch,

8
lib/bdev/split/vbdev_split.c
View File

@ -270,12 +270,6 @@ vbdev_split_fini(void)
spdk_bdev_part_tailq_fini(&g_split_disks); spdk_bdev_part_tailq_fini(&g_split_disks);
} }
static int
vbdev_split_get_ctx_size(void)
{
return 0;
}
SPDK_BDEV_MODULE_REGISTER(split, vbdev_split_init, vbdev_split_fini, NULL, SPDK_BDEV_MODULE_REGISTER(split, vbdev_split_init, vbdev_split_fini, NULL,
vbdev_split_get_ctx_size, vbdev_split_examine) NULL, vbdev_split_examine)
SPDK_LOG_REGISTER_TRACE_FLAG("vbdev_split", SPDK_TRACE_VBDEV_SPLIT) SPDK_LOG_REGISTER_TRACE_FLAG("vbdev_split", SPDK_TRACE_VBDEV_SPLIT)