ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lvol: return meaningful RPC errors

Browse Source 
Signed-off-by: Maciej Szwed <maciej.szwed@intel.com>
Change-Id: If809fe808150498c7ad6797855fda3097e3b0c84

Reviewed-on: https://review.gerrithub.io/382470
Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
This commit is contained in:
Maciej Szwed 2017-10-13 15:32:59 +02:00 committed by Jim Harris
parent 5bf109d507
commit f1c7998742
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/bdev/lvol/vbdev_lvol.c
View File

@ -558,13 +558,13 @@ vbdev_lvol_resize(char *name, size_t sz,
lvol = vbdev_get_lvol_by_name(name); lvol = vbdev_get_lvol_by_name(name);
if (lvol == NULL) { if (lvol == NULL) {
SPDK_ERRLOG("lvol '%s' does not exist\n", name); SPDK_ERRLOG("lvol '%s' does not exist\n", name);
return -1; return -ENODEV;
} }
bdev = spdk_bdev_get_by_name(name); bdev = spdk_bdev_get_by_name(name);
if (bdev == NULL) { if (bdev == NULL) {
SPDK_ERRLOG("bdev '%s' does not exist\n", name); SPDK_ERRLOG("bdev '%s' does not exist\n", name);
return -1; return -ENODEV;
} }
lvs = lvol->lvol_store; lvs = lvol->lvol_store;

1
lib/bdev/lvol/vbdev_lvol_rpc.c
View File

@ -362,6 +362,7 @@ spdk_rpc_resize_lvol_bdev(struct spdk_jsonrpc_request *request,
if (req.name == NULL) { if (req.name == NULL) {
SPDK_ERRLOG("missing name param\n"); SPDK_ERRLOG("missing name param\n");
rc = -EINVAL;
goto invalid; goto invalid;
} }

2
lib/lvol/lvol.c
View File

@ -342,6 +342,8 @@ _spdk_lvol_create_open_cb(void *cb_arg, struct spdk_blob *blob, int lvolerrno)
lvol->name = spdk_sprintf_alloc("%s_%"PRIu64, uuid, (uint64_t)blob_id); lvol->name = spdk_sprintf_alloc("%s_%"PRIu64, uuid, (uint64_t)blob_id);
if (!lvol->name) { if (!lvol->name) {
spdk_bs_md_close_blob(&blob, _spdk_lvol_delete_blob_cb, lvol); spdk_bs_md_close_blob(&blob, _spdk_lvol_delete_blob_cb, lvol);
SPDK_ERRLOG("Cannot alloc memory for lvol name\n");
lvolerrno = -ENOMEM;
goto invalid; goto invalid;
} }