From f18f8e930a625d44fdf8d39dbdd796694cb154d5 Mon Sep 17 00:00:00 2001
From: Seth Howell <seth.howell@intel.com>
Date: Mon, 20 Apr 2020 18:51:25 -0700
Subject: [PATCH] lib/iscsi: get rid of some unreachable code.

Fix kw warning 12457

Signed-off-by: Seth Howell <seth.howell@intel.com>
Change-Id: I5ab34269eb6a55a012b8fb4e109a42a3508e4193
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1951
Community-CI: Mellanox Build Bot
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
---
 lib/iscsi/iscsi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/iscsi/iscsi.c b/lib/iscsi/iscsi.c
index 3b6e0f4e7..27a856e3b 100644
--- a/lib/iscsi/iscsi.c
+++ b/lib/iscsi/iscsi.c
@@ -3834,10 +3834,8 @@ iscsi_pdu_payload_op_nopout(struct spdk_iscsi_conn *conn, struct spdk_iscsi_pdu
 
 	/* response PDU */
 	rsp_pdu = iscsi_get_pdu(conn);
-	if (rsp_pdu == NULL) {
-		free(data);
-		return SPDK_ISCSI_CONNECTION_FATAL;
-	}
+	assert(rsp_pdu != NULL);
+
 	rsph = (struct iscsi_bhs_nop_in *)&rsp_pdu->bhs;
 	rsp_pdu->data = data;
 	rsph->opcode = ISCSI_OP_NOPIN;