ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

util/string: additional errno check after strtol()

Browse Source 
Without this check valgrind complains that we are using
uninitialized variable.

Change-Id: I5cb73d10e167004f6e4df9e3621ec3b35ec2448d
Signed-off-by: Wojciech Malikowski <wojciech.malikowski@intel.com>
Reviewed-on: https://review.gerrithub.io/c/442519
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Wojciech Malikowski 2019-01-29 03:37:58 -05:00 committed by Jim Harris
parent 6903c407a5
commit f0e6bbea0a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/util/string.c
View File

@ -425,7 +425,7 @@ spdk_strtol(const char *nptr, int base)
val = strtol(nptr, &endptr, base); val = strtol(nptr, &endptr, base);
if (*endptr != '\0') { if (!errno && *endptr != '\0') {
/* Non integer character was found. */ /* Non integer character was found. */
return -EINVAL; return -EINVAL;
} else if (errno == ERANGE && (val == LONG_MAX || val == LONG_MIN)) { } else if (errno == ERANGE && (val == LONG_MAX || val == LONG_MIN)) {
@ -456,7 +456,7 @@ spdk_strtoll(const char *nptr, int base)
val = strtoll(nptr, &endptr, base); val = strtoll(nptr, &endptr, base);
if (*endptr != '\0') { if (!errno && *endptr != '\0') {
/* Non integer character was found. */ /* Non integer character was found. */
return -EINVAL; return -EINVAL;
} else if (errno == ERANGE && (val == LLONG_MAX || val == LLONG_MIN)) { } else if (errno == ERANGE && (val == LLONG_MAX || val == LLONG_MIN)) {