From ee9db7dac0ee61a85f56dc8d8353b02205d0e6ad Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Tue, 17 Jul 2018 11:05:33 +0800 Subject: [PATCH] blobstore: adjust order in spdk_xattr It will save the space of spdk_xattr when put uint16_t after uint32_t Change-Id: Ie0712d8c3b16d90fc354847509fd87e1ffd93916 Signed-off-by: Ziye Yang Reviewed-on: https://review.gerrithub.io/419453 Chandler-Test-Pool: SPDK Automated Test System Tested-by: SPDK CI Jenkins Reviewed-by: Shuhei Matsumoto Reviewed-by: Ben Walker Reviewed-by: Changpeng Liu --- lib/blob/blobstore.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/blob/blobstore.h b/lib/blob/blobstore.h index 755fc5938..61e6b38e7 100644 --- a/lib/blob/blobstore.h +++ b/lib/blob/blobstore.h @@ -53,11 +53,10 @@ #define SPDK_BLOB_BLOBID_HIGH_BIT (1ULL << 32) struct spdk_xattr { - /* TODO: reorder for best packing */ uint32_t index; + uint16_t value_len; char *name; void *value; - uint16_t value_len; TAILQ_ENTRY(spdk_xattr) link; };