From edaf193e21124414701f218598ec8308f14bd075 Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Thu, 2 Sep 2021 11:15:14 +0200 Subject: [PATCH] doc/shfmt: Add note about minimal version of Bash Signed-off-by: Michal Berger Change-Id: Id480d98cfe29f6c7676a39c0bfaf777ba54a6049 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9371 Tested-by: SPDK CI Jenkins Community-CI: Broadcom CI Reviewed-by: Shuhei Matsumoto Reviewed-by: Jim Harris --- doc/shfmt.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/shfmt.md b/doc/shfmt.md index c4aae79ad..08d22af97 100644 --- a/doc/shfmt.md +++ b/doc/shfmt.md @@ -15,6 +15,9 @@ formatter, shfmt, was introduced to help keep the .sh code consistent across the entire repo. For more details on the tool itself, please see [shfmt](https://github.com/mvdan/sh). +We also advise to use 4.4 Bash as a minimum version to make sure scripts +across the whole repo work as intended. + ## Usage {#shfmt_usage} On the CI pool, the shfmt is run against all the updated .sh files that