From ebeac5deccc2bcdd25183e6bc6cfb6bc5c6e6d31 Mon Sep 17 00:00:00 2001 From: GangCao Date: Mon, 12 Apr 2021 17:34:51 -0400 Subject: [PATCH] event: add an assert check for obtained reactor In the case that reactor is needed to be valid, add an explicit assert there. Change-Id: Ic47030d50a6a940ddf87a3744bae38c94dd7252e Signed-off-by: GangCao Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7320 Tested-by: SPDK CI Jenkins Reviewed-by: Reviewed-by: Xiaodong Liu Reviewed-by: Jim Harris Reviewed-by: Ben Walker Community-CI: Mellanox Build Bot --- lib/event/reactor.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/event/reactor.c b/lib/event/reactor.c index b2c802180..414662572 100644 --- a/lib/event/reactor.c +++ b/lib/event/reactor.c @@ -353,6 +353,7 @@ _reactor_set_notify_cpuset(void *arg1, void *arg2) struct spdk_reactor *target = arg1; struct spdk_reactor *reactor = spdk_reactor_get(spdk_env_get_current_core()); + assert(reactor != NULL); spdk_cpuset_set_cpu(&reactor->notify_cpuset, target->lcore, target->new_in_interrupt); } @@ -715,6 +716,7 @@ _reactors_scheduler_update_core_mode(void *ctx) } reactor = spdk_reactor_get(g_scheduler_core_number); + assert(reactor != NULL); if (reactor->in_interrupt != g_core_infos[g_scheduler_core_number].interrupt_mode) { /* Switch next found reactor to new state */ rc = spdk_reactor_set_interrupt_mode(g_scheduler_core_number, @@ -1078,6 +1080,8 @@ thread_process_interrupts(void *arg) uint64_t now; int rc; + assert(reactor != NULL); + /* Update idle_tsc between the end of last intr_fn and the start of this intr_fn. */ now = spdk_get_ticks(); reactor->idle_tsc += now - reactor->tsc_last;