From ea91da8d2d262fd79cdbc7880a2b630597ef14d0 Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Fri, 17 Feb 2023 23:31:29 +0100 Subject: [PATCH] pkgdep: Install git at the default /usr/local/bin dir There's no point in keeping track of the extra path and pollute the global bash profiles with it. Just put the target binary under the /usr/local/bin which most distros, including centos7 keep in their $PATH. Also, drop the proxyconf mention as we are not using it anymore. Signed-off-by: Michal Berger Change-Id: I2a531fb140aea4c87ad8c3f053a39d262d2d02ae Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16853 Reviewed-by: Tomasz Zawadzki Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Reviewed-by: Pawel Piatek --- test/common/config/pkgdep/git | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/test/common/config/pkgdep/git b/test/common/config/pkgdep/git index 07559dcf0..7ad3d717d 100644 --- a/test/common/config/pkgdep/git +++ b/test/common/config/pkgdep/git @@ -346,12 +346,8 @@ function install_git() { tar -C "$GIT_REPOS" -xzof <(wget -qO- "$GIT_REPO_GIT") (cd "$GIT_REPOS/git-$GIT_VERSION" \ && make configure \ - && ./configure --prefix=/usr/local/git \ + && ./configure \ && sudo make -j${jobs} install) - sudo sh -c "echo 'export PATH=/usr/local/git/bin:$PATH' >> /etc/bashrc" - export "PATH=/usr/local/git/bin:$PATH" - # Be nice for vagrant-proxyconf setup - mkdir -p "/usr/local/git/etc" } function install_extra_pkgs() {