From ea88aefbf892bb748b7dfc15e42ed75a164aebca Mon Sep 17 00:00:00 2001 From: Dariusz Stojaczyk Date: Tue, 6 Feb 2018 14:47:29 +0100 Subject: [PATCH] test/bdevperf: fix memory leak if opening a descriptor fails This was probably overlooked when developing 57d174ff6. Fixes: 57d174ff6 ("bdev: add spdk_bdev_open/close") Change-Id: Idb30287e740ac0300a5c7dc9fad7e06693f58330 Signed-off-by: Dariusz Stojaczyk Reviewed-on: https://review.gerrithub.io/398585 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Jim Harris --- test/lib/bdev/bdevperf/bdevperf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/lib/bdev/bdevperf/bdevperf.c b/test/lib/bdev/bdevperf/bdevperf.c index 3907d468b..6bf3bfb4d 100644 --- a/test/lib/bdev/bdevperf/bdevperf.c +++ b/test/lib/bdev/bdevperf/bdevperf.c @@ -206,6 +206,8 @@ bdevperf_construct_targets(void) rc = spdk_bdev_open(bdev, true, NULL, NULL, &target->bdev_desc); if (rc != 0) { SPDK_ERRLOG("Could not open leaf bdev %s, error=%d\n", spdk_bdev_get_name(bdev), rc); + free(target->name); + free(target); bdev = spdk_bdev_next_leaf(bdev); continue; }