From e9dff4398227c862fd36da9cc8211d1d593670fc Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Mon, 11 Dec 2017 17:07:14 +0900 Subject: [PATCH] env: Check return value of rte_mempool_get in spdk_mempool_get According to the rte_mempool.h, the retrieved pointer will be valid when rte_mempool_get() returns 0. Change-Id: Iac8a62f9dd39cd7b70478009503f17d78375a124 Signed-off-by: Shuhei Matsumoto Reviewed-on: https://review.gerrithub.io/391161 Tested-by: SPDK Automated Test System Reviewed-by: Daniel Verkamp Reviewed-by: Ben Walker --- lib/env_dpdk/env.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/env_dpdk/env.c b/lib/env_dpdk/env.c index 716a9ca95..2ffd01324 100644 --- a/lib/env_dpdk/env.c +++ b/lib/env_dpdk/env.c @@ -189,9 +189,12 @@ void * spdk_mempool_get(struct spdk_mempool *mp) { void *ele = NULL; + int rc; - rte_mempool_get((struct rte_mempool *)mp, &ele); - + rc = rte_mempool_get((struct rte_mempool *)mp, &ele); + if (rc != 0) { + return NULL; + } return ele; }