From e93ba047acd98ab3f727a8987f16374acd3ce044 Mon Sep 17 00:00:00 2001 From: Shuhei Matsumoto Date: Tue, 16 Aug 2022 07:42:39 +0900 Subject: [PATCH] nvme: Restore complete_abort_queued_reqs() call into process_completions() spdk_nvme_qpair_process_completions() had called always _nvme_qpair_complete_abort_queued_reqs() at its end. However, the call was accidentally removed by a commit https://github.com/spdk/spdk/commit/59c8bb527b98301fedfd5445874bbcc59bc5bb67 to fix an issue. By this removal, aborting request was not completed for some error cases. Fix the degradation by restoring the call. Signed-off-by: Shuhei Matsumoto Change-Id: I0099eb7a008f823e1282576504423cdc248911d7 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/14045 Reviewed-by: Michael Haeuptle Reviewed-by: Aleksey Marchuk Reviewed-by: Jim Harris Tested-by: SPDK CI Jenkins Community-CI: Mellanox Build Bot --- lib/nvme/nvme_qpair.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/nvme/nvme_qpair.c b/lib/nvme/nvme_qpair.c index 4d39a11e6..059398851 100644 --- a/lib/nvme/nvme_qpair.c +++ b/lib/nvme/nvme_qpair.c @@ -761,6 +761,8 @@ spdk_nvme_qpair_process_completions(struct spdk_nvme_qpair *qpair, uint32_t max_ */ if (ret > 0) { nvme_qpair_resubmit_requests(qpair, ret); + } else { + _nvme_qpair_complete_abort_queued_reqs(qpair); } return ret;