From e6f5dbb02b748f6605b8b89a98504da1662df1e2 Mon Sep 17 00:00:00 2001 From: Konrad Sztyber Date: Fri, 17 Mar 2023 09:36:42 +0100 Subject: [PATCH] test/unit: add missing jsonrpc stubs It fixes the following error under clang: /usr/bin/ld.bfd: bdev_nvme_ut.o: in function `bdev_nvme_get_mdns_discovery_info': /home/ksztyber/src/spdk/module/bdev/nvme/bdev_mdns_client.c:578: undefined reference to `spdk_jsonrpc_begin_result' /usr/bin/ld.bfd: /home/ksztyber/src/spdk/module/bdev/nvme/bdev_mdns_client.c:599: undefined reference to `spdk_jsonrpc_end_result' It probably works on gcc, because the bdev_nvme_get_mdns_discovery_info isn't called anywhere in the unit test and gets optimized away. Fixes #2950 Signed-off-by: Konrad Sztyber Change-Id: I2bb856afbc1a1a7e882dec72e4182ad9d3b9b24a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/17260 Tested-by: SPDK CI Jenkins Reviewed-by: Jim Harris Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker Reviewed-by: Karol Latecki --- test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c b/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c index 7107a0476..82917f3f5 100644 --- a/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c +++ b/test/unit/lib/bdev/nvme/bdev_nvme.c/bdev_nvme_ut.c @@ -51,6 +51,10 @@ DEFINE_RETURN_MOCK(spdk_nvme_ctrlr_get_memory_domains, int); DEFINE_STUB_V(spdk_jsonrpc_send_error_response, (struct spdk_jsonrpc_request *request, int error_code, const char *msg)); +DEFINE_STUB(spdk_jsonrpc_begin_result, struct spdk_json_write_ctx *, + (struct spdk_jsonrpc_request *request), NULL); +DEFINE_STUB_V(spdk_jsonrpc_end_result, + (struct spdk_jsonrpc_request *request, struct spdk_json_write_ctx *w)); DEFINE_STUB_V(spdk_nvme_transport_get_opts, (struct spdk_nvme_transport_opts *opts, size_t opts_size));