From e5bf2a1966bf35ebcf969859496a3ee5a2be762c Mon Sep 17 00:00:00 2001 From: Jacek Kalwas Date: Mon, 29 Jun 2020 13:50:08 +0200 Subject: [PATCH] nvmf: fix aqa property validation Signed-off-by: Jacek Kalwas Change-Id: I4de16c80fda5a39cfcdb15badb0d37acd1a5a21c Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3102 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Jim Harris --- lib/nvmf/ctrlr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/nvmf/ctrlr.c b/lib/nvmf/ctrlr.c index 638cde9d2..fb61849e1 100644 --- a/lib/nvmf/ctrlr.c +++ b/lib/nvmf/ctrlr.c @@ -867,8 +867,8 @@ nvmf_prop_set_aqa(struct spdk_nvmf_ctrlr *ctrlr, uint32_t value) aqa.raw = value; - if (aqa.bits.asqs > ctrlr->vcprop.cap.bits.mqes || - aqa.bits.acqs > ctrlr->vcprop.cap.bits.mqes) { + if (aqa.bits.asqs < SPDK_NVME_ADMIN_QUEUE_MIN_ENTRIES - 1 || + aqa.bits.acqs < SPDK_NVME_ADMIN_QUEUE_MIN_ENTRIES - 1) { return false; }