From e3b90fe2d512a694f950666fad49b08a2042b824 Mon Sep 17 00:00:00 2001 From: yidong0635 Date: Tue, 23 Jul 2019 05:01:10 -0400 Subject: [PATCH] bdev: Fix warning about potenial memory leak about histogram. Pointer passthrough g_histogram and histogram implicitly ,but the checker still complains about this, change to spdk_histogram_data_free(histogram) directly, no need any assert any more. bdev_ut.c:1486:2: warning: Potential leak of memory pointed to by 'histogram' poll_threads(); ^~~~~~~~~~~~~~ 1 warning generated. Change-Id: I609c1c92643ad03b8e3c62cd8434882e7942efa4 Signed-off-by: yidong0635 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/462789 Reviewed-by: Changpeng Liu Reviewed-by: Darek Stojaczyk Tested-by: SPDK CI Jenkins --- test/unit/lib/bdev/mt/bdev.c/bdev_ut.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c b/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c index e2c1b1ab9..0e8fdbfd1 100644 --- a/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c +++ b/test/unit/lib/bdev/mt/bdev.c/bdev_ut.c @@ -1498,7 +1498,7 @@ bdev_histograms_mt(void) CU_ASSERT(g_status == 0); CU_ASSERT(g_bdev.bdev.internal.histogram_enabled == false); - spdk_histogram_data_free(g_histogram); + spdk_histogram_data_free(histogram); /* Tear down the channels */ set_thread(0);