ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ut/bdev: fix scan-build reporting uninitalized values

Browse Source 
Scan-build on Fedora29/30 reports error, which this patch fixes:
bdev_ut.c:1436:17: warning: The left operand of '!=' is a garbage value
CU_ASSERT(desc != NULL);
~~~~ ^
/usr/include/CUnit/CUnit.h:123:30: note: expanded from macro 'CU_ASSERT'
{ CU_assertImplementation((value), LINE, #value, FILE, "", CU_FALSE); }
^~~~~
bdev_ut.c:1654:17: warning: The left operand of '!=' is a garbage value
CU_ASSERT(desc != NULL);
~~~~ ^
/usr/include/CUnit/CUnit.h:123:30: note: expanded from macro 'CU_ASSERT'
{ CU_assertImplementation((value), LINE, #value, FILE, "", CU_FALSE); }

Fixes #924

Change-Id: Ia7dc6ce066ac80fc45f022eefd43a224d2f11503
Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466110
Reviewed-by: Broadcom SPDK FC-NVMe CI <spdk-ci.pdl@broadcom.com>
Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
This commit is contained in:
Tomasz Zawadzki 2019-08-23 03:14:49 -04:00 committed by Jim Harris
parent fd0f036480
commit e2ce08cf68
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/lib/bdev/bdev.c/bdev_ut.c
View File

@ -1412,7 +1412,7 @@ static void
bdev_io_alignment(void) bdev_io_alignment(void)
{ {
struct spdk_bdev *bdev; struct spdk_bdev *bdev;
struct spdk_bdev_desc *desc; struct spdk_bdev_desc *desc = NULL;
struct spdk_io_channel *io_ch; struct spdk_io_channel *io_ch;
struct spdk_bdev_opts bdev_opts = { struct spdk_bdev_opts bdev_opts = {
.bdev_io_pool_size = 20, .bdev_io_pool_size = 20,
@ -1630,7 +1630,7 @@ static void
bdev_io_alignment_with_boundary(void) bdev_io_alignment_with_boundary(void)
{ {
struct spdk_bdev *bdev; struct spdk_bdev *bdev;
struct spdk_bdev_desc *desc; struct spdk_bdev_desc *desc = NULL;
struct spdk_io_channel *io_ch; struct spdk_io_channel *io_ch;
struct spdk_bdev_opts bdev_opts = { struct spdk_bdev_opts bdev_opts = {
.bdev_io_pool_size = 20, .bdev_io_pool_size = 20,