From e1946cd7997e8dcbfbbde67382f1dcc918cb513f Mon Sep 17 00:00:00 2001 From: Michal Berger Date: Tue, 3 Aug 2021 17:54:58 +0200 Subject: [PATCH] test/common: Add SERIAL to the last check in waitforserial_disconnect() The argument is meant to be SERIAL so the last check may erroneously force waitforserial_disconnect() to report success if lsblk is not told to include serial of the device in the output. Signed-off-by: Michal Berger Change-Id: Iee591597140658b1e611a84e65b280c565eecdfc Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9057 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins Reviewed-by: Changpeng Liu Reviewed-by: Tomasz Zawadzki Reviewed-by: Jim Harris --- test/common/autotest_common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/autotest_common.sh b/test/common/autotest_common.sh index 4b85c6179..e23ac1f21 100755 --- a/test/common/autotest_common.sh +++ b/test/common/autotest_common.sh @@ -1056,7 +1056,7 @@ function waitforserial_disconnect() { sleep 1 done - if lsblk -l -o NAME | grep -q -w $1; then + if lsblk -l -o NAME,SERIAL | grep -q -w $1; then return 1 fi