From e0c10939364d90245893066827870c6cb96b7eef Mon Sep 17 00:00:00 2001 From: Ziye Yang Date: Fri, 15 Feb 2019 22:45:35 +0800 Subject: [PATCH] event: Change the base to 0 when calling strtol Previously, we can -p + hex value(e.g., 0x1) to assign the master core and start the NVMe-oF or iSCSI target app. However now it is not supported and prints error. I checked the code, it only supports transformation with Decimal format, so chaning the base to 0 to make it supporting other formats. Change-Id: I82510ba0cef47b5593484b4fd3490f85c93cf6a5 Signed-off-by: Ziye Yang Reviewed-on: https://review.gerrithub.io/c/444830 (master) Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447593 Reviewed-by: Darek Stojaczyk Reviewed-by: Ben Walker Tested-by: SPDK CI Jenkins --- lib/event/app.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/event/app.c b/lib/event/app.c index 17a97aa7d..835e1ac67 100644 --- a/lib/event/app.c +++ b/lib/event/app.c @@ -857,7 +857,7 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts, retval = SPDK_APP_PARSE_ARGS_HELP; goto out; case SHM_ID_OPT_IDX: - opts->shm_id = spdk_strtol(optarg, 10); + opts->shm_id = spdk_strtol(optarg, 0); if (opts->shm_id < 0) { fprintf(stderr, "Invalid shared memory ID %s\n", optarg); goto out; @@ -867,14 +867,14 @@ spdk_app_parse_args(int argc, char **argv, struct spdk_app_opts *opts, opts->reactor_mask = optarg; break; case MEM_CHANNELS_OPT_IDX: - opts->mem_channel = spdk_strtol(optarg, 10); + opts->mem_channel = spdk_strtol(optarg, 0); if (opts->mem_channel < 0) { fprintf(stderr, "Invalid memory channel %s\n", optarg); goto out; } break; case MASTER_CORE_OPT_IDX: - opts->master_core = spdk_strtol(optarg, 10); + opts->master_core = spdk_strtol(optarg, 0); if (opts->master_core < 0) { fprintf(stderr, "Invalid master core %s\n", optarg); goto out;