From dfc4b030b1a267cbe02e3f8b419c70e7eb03b21b Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 16 May 2016 10:45:40 -0700 Subject: [PATCH] nvme: assert that outstanding_tr request is valid All trackers in outstanding_tr should have a non-NULL request. Add an assert to verify this. Fixes a clang warning during scan-build. Change-Id: I0ac4d2bad17449f684808cbb98777627d890b65b Signed-off-by: Daniel Verkamp --- lib/nvme/nvme_qpair.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/nvme/nvme_qpair.c b/lib/nvme/nvme_qpair.c index 04deca1f0..f3752252a 100644 --- a/lib/nvme/nvme_qpair.c +++ b/lib/nvme/nvme_qpair.c @@ -565,6 +565,7 @@ nvme_admin_qpair_abort_aers(struct spdk_nvme_qpair *qpair) tr = LIST_FIRST(&qpair->outstanding_tr); while (tr != NULL) { + nvme_assert(tr->req != NULL, ("tr->req == NULL in abort_aers\n")); if (tr->req->cmd.opc == SPDK_NVME_OPC_ASYNC_EVENT_REQUEST) { nvme_qpair_manual_complete_tracker(qpair, tr, SPDK_NVME_SCT_GENERIC, SPDK_NVME_SC_ABORTED_SQ_DELETION, 0,