ivampiresp/Spdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blobstore: mark blobstore dirty on extent page write

Browse Source 
When blobstore is shutdown unexpectedly the super block should
already be marked as dirty. Only when proper blobstore unload
happens, the super block is marked as clean.

Super block is not marked as dirty on blobstore load,
but on first action that starts to modify the metadata.
At this time it only happens through blob persist,
which is fine for creation/deletion of blobs or
their modification (resize/xattr).

It works for cluster allocation with extent_table disabled,
and when extent page needs to be allocated.

Yet it fails for cases when no new extent page is required.
It will result in not marking blobstore as dirty and
then fail when loading a particular blob due to mismatch
between used_clusters and contents of extent page.

To fix that, the blobstore is now marked dirty on a very first
extent page update since blobstore load.

Fixes #2830

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Change-Id: Ied37ecf90d46e1bc51b22c323dce278a0fa88f72
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/16179
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Reviewed-by: Ben Walker <benjamin.walker@intel.com>
This commit is contained in:
Tomasz Zawadzki 2023-01-17 11:30:35 +01:00
parent 87c59b28a3
commit dfa7f14bc4
1 changed files with 38 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
lib/blob/blobstore.c
View File

@ -7522,18 +7522,52 @@ blob_insert_new_ep_cb(void *arg, int bserrno)
blob_sync_md(ctx->blob, blob_insert_cluster_msg_cb, ctx);
}
struct spdk_blob_write_extent_page_ctx {
struct spdk_blob_store *bs;
uint32_t extent;
struct spdk_blob_md_page *page;
};
static void
blob_persist_extent_page_cpl(spdk_bs_sequence_t *seq, void *cb_arg, int bserrno)
{
struct spdk_blob_write_extent_page_ctx *ctx = cb_arg;
free(ctx);
bs_sequence_finish(seq, bserrno);
}
static void
blob_write_extent_page_ready(spdk_bs_sequence_t *seq, void *cb_arg, int bserrno)
{
struct spdk_blob_write_extent_page_ctx *ctx = cb_arg;
if (bserrno != 0) {
blob_persist_extent_page_cpl(seq, ctx, bserrno);
return;
}
bs_sequence_write_dev(seq, ctx->page, bs_md_page_to_lba(ctx->bs, ctx->extent),
bs_byte_to_lba(ctx->bs, SPDK_BS_PAGE_SIZE),
blob_persist_extent_page_cpl, ctx);
}
static void
blob_write_extent_page(struct spdk_blob *blob, uint32_t extent, uint64_t cluster_num,
struct spdk_blob_md_page *page, spdk_blob_op_complete cb_fn, void *cb_arg)
{
spdk_bs_sequence_t *seq;
struct spdk_bs_cpl cpl;
struct spdk_blob_write_extent_page_ctx *ctx;
spdk_bs_sequence_t *seq;
struct spdk_bs_cpl cpl;
ctx = calloc(1, sizeof(*ctx));
if (!ctx) {
cb_fn(cb_arg, -ENOMEM);
return;
}
ctx->bs = blob->bs;
ctx->extent = extent;
ctx->page = page;
cpl.type = SPDK_BS_CPL_TYPE_BLOB_BASIC;
cpl.u.blob_basic.cb_fn = cb_fn;
@ -7541,6 +7575,7 @@ blob_write_extent_page(struct spdk_blob *blob, uint32_t extent, uint64_t cluster
seq = bs_sequence_start(blob->bs->md_channel, &cpl);
if (!seq) {
free(ctx);
cb_fn(cb_arg, -ENOMEM);
return;
}
@ -7556,9 +7591,7 @@ blob_write_extent_page(struct spdk_blob *blob, uint32_t extent, uint64_t cluster
assert(spdk_bit_array_get(blob->bs->used_md_pages, extent) == true);
bs_sequence_write_dev(seq, page, bs_md_page_to_lba(blob->bs, extent),
bs_byte_to_lba(blob->bs, SPDK_BS_PAGE_SIZE),
blob_persist_extent_page_cpl, page);
bs_mark_dirty(seq, blob->bs, blob_write_extent_page_ready, ctx);
}
static void