From de8b8712f8d3d6eb23cb43c54dd45f2e31d8d0e2 Mon Sep 17 00:00:00 2001 From: Daniel Verkamp Date: Mon, 28 Nov 2016 14:09:56 -0700 Subject: [PATCH] nvme/rdma: remove unused outstanding_reqs counter The only place where outstanding_reqs was checked was in nvme_rdma_req_put(), but the error case there could only happen if some kind of internal programming error occurred (e.g. calling nvme_rdma_req_put() on an invalid request). Change-Id: I71e40ce562a8720dfaf70437ffd4c6493327c091 Signed-off-by: Daniel Verkamp --- lib/nvme/nvme_rdma.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/lib/nvme/nvme_rdma.c b/lib/nvme/nvme_rdma.c index 233951992..1a4484993 100644 --- a/lib/nvme/nvme_rdma.c +++ b/lib/nvme/nvme_rdma.c @@ -80,8 +80,6 @@ struct nvme_rdma_ctrlr { struct nvme_rdma_qpair { struct spdk_nvme_qpair qpair; - uint16_t outstanding_reqs; - struct rdma_event_channel *cm_channel; struct rdma_cm_id *cm_id; @@ -155,7 +153,6 @@ nvme_rdma_req_get(struct nvme_rdma_qpair *rqpair) rdma_req = STAILQ_FIRST(&rqpair->free_reqs); STAILQ_REMOVE(&rqpair->free_reqs, rdma_req, spdk_nvme_rdma_req, link); - rqpair->outstanding_reqs++; return rdma_req; } @@ -173,12 +170,7 @@ nvme_rdma_req_put(struct spdk_nvme_rdma_req *rdma_req) return; } - if (rqpair->outstanding_reqs) { - rqpair->outstanding_reqs--; - STAILQ_INSERT_HEAD(&rqpair->free_reqs, rdma_req, link); - } else { - SPDK_ERRLOG("There is no outstanding IOs\n"); - } + STAILQ_INSERT_HEAD(&rqpair->free_reqs, rdma_req, link); } static void @@ -1338,7 +1330,6 @@ nvme_rdma_qpair_construct(struct spdk_nvme_qpair *qpair) return -1; } - rqpair->outstanding_reqs = 0; STAILQ_INIT(&rqpair->free_reqs); SPDK_TRACELOG(SPDK_TRACE_DEBUG, "qpair num entries = %d\n", qpair->num_entries);